You are viewing a plain text version of this content. The canonical link for it is here.

Posted to user@hbase.apache.org by Adam Sjøgren <ad...@novonesis.com.INVALID> on 2025/08/12 13:29:22 UTC

Adding support for cellVisibility in Thrift interface

  Hi,


Years ago, one of my colleagues added support for cellVisibility in
the Thrift interface of HBase, in a local patch, we have been carrying
forward since.

The change is quite small:

   4 lines in hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java,
   2 lines in hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
  92 lines in hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java

What is the right way to contribute this change to HBase?


  Best regards,

    Adam

-- 
 "No more than that, but very powerful all the                Adam Sjøgren
  same; simple things are good."                        adsj@novonesis.com

Re: Adding support for cellVisibility in Thrift interface

Posted by Adam Sjøgren <ad...@novonesis.com.INVALID>.

张铎(Duo Zhang) writes:

> Ah, you can file an issue and then upload the patch as an attachment.

Great - I have done so now:

  Support for cellVisibility in Thrift interface
   · https://issues.apache.org/jira/browse/HBASE-29528

> Our committers will help open a PR to see if it works. Only pre commit
> checks are running on github so we must use github PR to verify the
> patch...

Sounds good.


  Thanks!

   Adam

-- 
 "No more than that, but very powerful all the                Adam Sjøgren
  same; simple things are good."                        adsj@novonesis.com

Re: Adding support for cellVisibility in Thrift interface

Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.

Ah, you can file an issue and then upload the patch as an attachment.

Our committers will help open a PR to see if it works. Only pre commit
checks are running on github so we must use github PR to verify the
patch...

Thanks.

Adam Sjøgren <ad...@novonesis.com.invalid> 于2025年8月13日周三 15:49写道：
>
> 张铎(Duo Zhang) writes:
>
> > Please see the 'How to contribute' section in the README.md, HBase
> > uses jira for tracking issues and github PRs to accept patches.
>
> Uh-oh, I don't use GitHub. Is there any way to contribute without a
> GitHub account?
>
> Perhaps I can find a colleague who has an account.
>
> > You need to visit https://selfserve.apache.org/jira-account.html to
> > request a jira account first, and then open an issue about the change,
> > and then open a PR on github, where the title of the issue starts with
> > the jira id('HBASE-12345' for example), then committers will review
> > and merge the PR, and then close the issue.
>
> Thanks for the guidance - I have requested a Jira account now.
>
>
>   Best regards,
>
>     Adam
>
> --
>  "No more than that, but very powerful all the                Adam Sjøgren
>   same; simple things are good."                        adsj@novonesis.com
>

Re: Adding support for cellVisibility in Thrift interface

Posted by Adam Sjøgren <ad...@novonesis.com.INVALID>.

张铎(Duo Zhang) writes:

> Please see the 'How to contribute' section in the README.md, HBase
> uses jira for tracking issues and github PRs to accept patches.

Uh-oh, I don't use GitHub. Is there any way to contribute without a
GitHub account?

Perhaps I can find a colleague who has an account.

> You need to visit https://selfserve.apache.org/jira-account.html to
> request a jira account first, and then open an issue about the change,
> and then open a PR on github, where the title of the issue starts with
> the jira id('HBASE-12345' for example), then committers will review
> and merge the PR, and then close the issue.

Thanks for the guidance - I have requested a Jira account now.


  Best regards,

    Adam

-- 
 "No more than that, but very powerful all the                Adam Sjøgren
  same; simple things are good."                        adsj@novonesis.com

Re: Adding support for cellVisibility in Thrift interface

Posted by "张铎(Duo Zhang)" <pa...@gmail.com>.

Thanks for contributing!

Please see the 'How to contribute' section in the README.md, HBase
uses jira for tracking issues and github PRs to accept patches.

You need to visit https://selfserve.apache.org/jira-account.html to
request a jira account first, and then open an issue about the change,
and then open a PR on github, where the title of the issue starts with
the jira id('HBASE-12345' for example), then committers will review
and merge the PR, and then close the issue.

Thanks.

Adam Sjøgren <ad...@novonesis.com.invalid> 于2025年8月12日周二 21:29写道：
>
>   Hi,
>
>
> Years ago, one of my colleagues added support for cellVisibility in
> the Thrift interface of HBase, in a local patch, we have been carrying
> forward since.
>
> The change is quite small:
>
>    4 lines in hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/ThriftUtilities.java,
>    2 lines in hbase-thrift/src/main/resources/org/apache/hadoop/hbase/thrift2/hbase.thrift
>   92 lines in hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift2/TestThriftHBaseServiceHandlerWithLabels.java
>
> What is the right way to contribute this change to HBase?
>
>
>   Best regards,
>
>     Adam
>
> --
>  "No more than that, but very powerful all the                Adam Sjøgren
>   same; simple things are good."                        adsj@novonesis.com
>