You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/09 12:07:10 UTC

[GitHub] [arrow-datafusion] xudong963 commented on pull request #2177: udtf support

xudong963 commented on PR #2177:
URL: https://github.com/apache/arrow-datafusion/pull/2177#issuecomment-1093964538

   BTW, from clippy:
   ```
   error: unneeded `return` statement
      --> datafusion/core/src/physical_plan/functions.rs:752:9
       |
   752 |         return Ok(ColumnarValue::Array(result));
       |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return`: `Ok(ColumnarValue::Array(result))`
       |
       = note: `-D clippy::needless-return` implied by `-D warnings`
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   
   error: could not compile `datafusion` due to previous error
   warning: build failed, waiting for other jobs to finish...
   error: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
       --> datafusion/core/src/execution/context.rs:3527:32
        |
   3527 |             let start_number = start_arr.into_iter().nth(0).unwrap().unwrap_or(0);
        |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `start_arr.into_iter().next()`
        |
        = note: `-D clippy::iter-nth-zero` implied by `-D warnings`
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
   
   error: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
       --> datafusion/core/src/execution/context.rs:3533:30
        |
   3533 |             let end_number = end_arr.into_iter().nth(0).unwrap().unwrap_or(0) + 1;
        |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `end_arr.into_iter().next()`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
   
   error: build failed
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org