[GitHub] [maven-release] michael-o commented on a change in pull request #86: MRELEASE-1072 reuse original tag for next development version in case

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #86:
URL: https://github.com/apache/maven-release/pull/86#discussion_r777694580



##########
File path: maven-release-manager/src/main/java/org/apache/maven/shared/release/phase/RewritePomsForDevelopmentPhase.java
##########
@@ -65,7 +65,19 @@ protected void transformScm( MavenProject project, Model modelTarget, ReleaseDes
                         scmRoot.setConnection( scm.getConnection() );
                         scmRoot.setDeveloperConnection( scm.getDeveloperConnection() );
                         scmRoot.setUrl( scm.getUrl() );
-                        scmRoot.setTag( translator.resolveTag( scm.getTag() ) );
+                        String tag = translator.resolveTag( scm.getTag() );

Review comment:
       Still, can you take a look at `CvsScmTranslator`? It basically does what you do here. Can this be limited insite the Subversion translator?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org