[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #5345: Create PULL_REQUEST_TEMPLATE.md

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #5345:
URL: https://github.com/apache/incubator-pinot/pull/5345#discussion_r422412379



##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,13 @@
+## Upgrade Notes
+Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
+* [ ] Yes (Please label as **<code>backward-incompat</code>**)
+
+Does this PR fix a zero-downtime upgrade introduced earlier?
+* [ ] Yes (Please label this as **<code>backward-incompat</code>**)

Review comment:
       This bullet is not very intuitive to me. Are we saying that if you broke zero downtime upgrade earlier and now fixing it as part of this PR then label it backward incompat? That should be backward compatible. We recently had this scenario.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org