[GitHub] [kafka] rhauch commented on pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

[GitBox <gi...@apache.org>]

rhauch commented on pull request #9347:
URL: https://github.com/apache/kafka/pull/9347#issuecomment-702915039


   @soondenana if the goal is to minimize the changes, would it be sufficient to change the code to use `Time.sleep(...)` instead of `Thread.sleep(...)`, and then change the `SystemTime.sleep(...)` implementation to return immediately if the supplied number of milliseconds is <= 0?
   
   Are there performance implications of using `System.nanoTime()` instead of `System.currentTimeMillis()`?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org