You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ja...@apache.org on 2016/11/15 14:48:51 UTC
[1/2] incubator-carbondata git commit: implement test cases for
core.load module
Repository: incubator-carbondata
Updated Branches:
refs/heads/master 6fe4f96e1 -> e60c9255f
implement test cases for core.load module
code formatted using formatter
replace assert with assertEquals
manage test case for timestamp
Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/70537a6c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/70537a6c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/70537a6c
Branch: refs/heads/master
Commit: 70537a6cf8d04dcb4be216e4b54f72974e2f3ae1
Parents: 6fe4f96
Author: Anurag <an...@knoldus.com>
Authored: Fri Oct 28 10:34:51 2016 +0530
Committer: jackylk <ja...@huawei.com>
Committed: Tue Nov 15 21:02:31 2016 +0800
----------------------------------------------------------------------
.../core/load/LoadMetadataDetails.java | 2 +-
.../core/load/LoadMetadataDetailsUnitTest.java | 134 +++++++++++++++++++
2 files changed, 135 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/70537a6c/core/src/main/java/org/apache/carbondata/core/load/LoadMetadataDetails.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/load/LoadMetadataDetails.java b/core/src/main/java/org/apache/carbondata/core/load/LoadMetadataDetails.java
index 7c58ae7..d527ba4 100644
--- a/core/src/main/java/org/apache/carbondata/core/load/LoadMetadataDetails.java
+++ b/core/src/main/java/org/apache/carbondata/core/load/LoadMetadataDetails.java
@@ -150,7 +150,7 @@ public class LoadMetadataDetails implements Serializable {
* return loadStartTime
* @return
*/
- public long getLoadStartTimeAsLong() {
+ public Long getLoadStartTimeAsLong() {
return getTimeStamp(loadStartTime);
}
http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/70537a6c/core/src/test/java/org/apache/carbondata/core/load/LoadMetadataDetailsUnitTest.java
----------------------------------------------------------------------
diff --git a/core/src/test/java/org/apache/carbondata/core/load/LoadMetadataDetailsUnitTest.java b/core/src/test/java/org/apache/carbondata/core/load/LoadMetadataDetailsUnitTest.java
new file mode 100644
index 0000000..4aed38f
--- /dev/null
+++ b/core/src/test/java/org/apache/carbondata/core/load/LoadMetadataDetailsUnitTest.java
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.carbondata.core.load;
+
+import java.text.ParseException;
+import java.text.SimpleDateFormat;
+import java.util.TimeZone;
+
+import org.apache.carbondata.common.logging.LogService;
+import org.apache.carbondata.common.logging.LogServiceFactory;
+import org.apache.carbondata.core.constants.CarbonCommonConstants;
+
+import org.junit.Before;
+import org.junit.Test;
+
+import static junit.framework.Assert.assertEquals;
+import static junit.framework.Assert.assertNotSame;
+import static junit.framework.Assert.assertNull;
+
+public class LoadMetadataDetailsUnitTest {
+
+ private LoadMetadataDetails loadMetadataDetails;
+ private static final LogService LOGGER =
+ LogServiceFactory.getLogService(LoadMetadataDetails.class.getName());
+
+ @Before public void setup() {
+ loadMetadataDetails = new LoadMetadataDetails();
+ }
+
+ /**
+ * This method will test Hashcode which will return 31 if we don't set loadName.
+ *
+ * @throws Exception
+ */
+
+ @Test public void testHashCodeLoadNameNull() throws Exception {
+ int expected_result = 31;
+ int data = loadMetadataDetails.hashCode();
+ assertEquals(expected_result, data);
+ }
+
+ @Test public void testHashCodeValueInLoadName() throws Exception {
+ loadMetadataDetails.setLoadName("test");
+ int data = loadMetadataDetails.hashCode();
+ assertNotSame(31, data);
+ }
+
+ @Test public void testEqualsObjectIsNotLoadMetadataDetails() throws Exception {
+ Object obj = new Object();
+ boolean result = loadMetadataDetails.equals(obj);
+ assertEquals(false, result);
+ }
+
+ @Test public void testEqualsObjectIsNull() throws Exception {
+ boolean result = loadMetadataDetails.equals(new Object());
+ assertEquals(false, result);
+ }
+
+ @Test public void testEqualsObjectIsLoadMetadataDetailsWithoutLoadName() throws Exception {
+ LoadMetadataDetails obj = new LoadMetadataDetails();
+ boolean result = loadMetadataDetails.equals(obj);
+ assertEquals(true, result);
+ }
+
+ @Test public void testEqualsObjectIsLoadMetadataDetails() throws Exception {
+ loadMetadataDetails.setLoadName("test");
+ LoadMetadataDetails obj = new LoadMetadataDetails();
+ boolean result = loadMetadataDetails.equals(obj);
+ assertEquals(false, result);
+ }
+
+ @Test public void testEqualsObjectIsLoadMetadataDetailsLoadNameNull() throws Exception {
+ LoadMetadataDetails obj = new LoadMetadataDetails();
+ obj.setLoadName("test");
+ boolean result = loadMetadataDetails.equals(obj);
+ assertEquals(false, result);
+ }
+
+ @Test public void testEqualsObjectIsLoadMetadataDetailsLoadNameEqualsObjectLoadName()
+ throws Exception {
+ loadMetadataDetails.setLoadName("test");
+ LoadMetadataDetails obj = new LoadMetadataDetails();
+ obj.setLoadName("test");
+ boolean result = loadMetadataDetails.equals(obj);
+ assertEquals(true, result);
+ }
+
+ @Test public void testGetTimeStampWithEmptyTimeStamp() throws Exception {
+ loadMetadataDetails.setLoadStartTime("");
+ Long result = loadMetadataDetails.getLoadStartTimeAsLong();
+ assertNull(result);
+ }
+
+ @Test public void testGetTimeStampWithParserException() throws Exception {
+ loadMetadataDetails.setLoadStartTime("00.00.00");
+ Long result = loadMetadataDetails.getLoadStartTimeAsLong();
+ assertNull(result);
+ }
+
+ @Test public void testGetTimeStampWithDate() throws Exception {
+ String date = "01-01-2016 00:00:00";
+ loadMetadataDetails.setLoadStartTime(date);
+ Long expected_result = getTime(date);
+ Long result = loadMetadataDetails.getLoadStartTimeAsLong();
+ assertEquals(expected_result, result);
+ }
+
+ public static Long getTime(String date) {
+ SimpleDateFormat simpleDateFormat = new SimpleDateFormat(CarbonCommonConstants.CARBON_TIMESTAMP);
+ try {
+ return simpleDateFormat.parse(date).getTime() * 1000;
+ } catch (ParseException e) {
+ LOGGER.error("Error while parsing " + date + " " + e.getMessage());
+ return null;
+ }
+ }
+}
[2/2] incubator-carbondata git commit: [CARBONDATA-340] implement
test cases for core.load module This closes #267
Posted by ja...@apache.org.
[CARBONDATA-340] implement test cases for core.load module This closes #267
Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/e60c9255
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/e60c9255
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/e60c9255
Branch: refs/heads/master
Commit: e60c9255f79b9dd67d02504c49ed348c2b42523f
Parents: 6fe4f96 70537a6
Author: jackylk <ja...@huawei.com>
Authored: Tue Nov 15 22:48:20 2016 +0800
Committer: jackylk <ja...@huawei.com>
Committed: Tue Nov 15 22:48:20 2016 +0800
----------------------------------------------------------------------
.../core/load/LoadMetadataDetails.java | 2 +-
.../core/load/LoadMetadataDetailsUnitTest.java | 134 +++++++++++++++++++
2 files changed, 135 insertions(+), 1 deletion(-)
----------------------------------------------------------------------