You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2018/07/17 21:54:59 UTC

Review Request 67950: Disabled override warnings for mocked methods.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67950/
-----------------------------------------------------------

Review request for mesos and Benjamin Bannier.


Repository: mesos


Description
-------

Clang can emit a `-Winconsistent-missing-override` warning for most
uses of the Google Mock `MOCK_METHOD` family of macros. See also
https://github.com/google/googletest/issues/533.


Diffs
-----

  src/tests/allocator.hpp 6139492bf4d18f31e558bd0216bcccd2705af4d7 
  src/tests/containerizer.hpp e05ce0323e032911d46d8682661ffe4463fdc276 
  src/tests/containerizer/docker_volume_isolator_tests.cpp c15a6fad642474765e4ad1952af6cd9ee937379e 
  src/tests/containerizer/isolator.hpp 5861b8b8abbba65c499aa57fbf489d0c74414a5b 
  src/tests/containerizer/launcher.hpp 6567e9663b3b8d143f4bc38421deee7876c19e37 
  src/tests/containerizer/mock_containerizer.hpp 8700257a9347199ed6e32b8b6b2a58787d68af03 
  src/tests/containerizer/provisioner_docker_tests.cpp bf56d603fcc1d99f73beca1871be45787fa1640d 
  src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed 
  src/tests/fetcher_tests.cpp f3ea7092635c88b9dddcc2998a4c7350fb56110c 
  src/tests/http_authentication_tests.cpp 0c2537408aff8b018d9af39f92bbab3ebad938be 
  src/tests/log_tests.cpp a8980e3676f51d14087f56338ff45de2927ea992 
  src/tests/mesos.hpp 8142f3f3ab8e4e9230efdcd2e6846d0e0bd293b2 
  src/tests/mock_csi_plugin.hpp 4642326b65ba7145bc57ac4a56d492697a7501b9 
  src/tests/mock_docker.hpp 4a2266fb1239cbc96c7df74b997212e3b3b01c75 
  src/tests/mock_fetcher.hpp fedb737ce42a1c68aa117e3db624c860d8afa7e4 
  src/tests/mock_registrar.hpp 2a13333e6dce433a4c53ec6639382aacaf0d9dc3 
  src/tests/mock_slave.hpp 9a74bf35d2cab0a72ba6376392239d8080a49304 
  src/tests/operation_status_update_manager_tests.cpp e6175700caefb47a95b1edc4ae41755f06781fb4 
  src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8 
  src/tests/uri_fetcher_tests.cpp 260ae9c96f78ee5528cbd61983e1d61bda48c23b 


Diff: https://reviews.apache.org/r/67950/diff/1/


Testing
-------

make check CXX=clang++ (Fedora 28)


Thanks,

James Peach

Re: Review Request 67950: Disabled override warnings for mocked methods.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67950/#review206182
-----------------------------------------------------------



PASS: Mesos patch 67950 was successfully built and tested.

Reviews applied: `['67950']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1945/mesos-review-67950

- Mesos Reviewbot Windows


On July 17, 2018, 2:54 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67950/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 2:54 p.m.)
> 
> 
> Review request for mesos and Benjamin Bannier.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Clang can emit a `-Winconsistent-missing-override` warning for most
> uses of the Google Mock `MOCK_METHOD` family of macros. See also
> https://github.com/google/googletest/issues/533.
> 
> 
> Diffs
> -----
> 
>   src/tests/allocator.hpp 6139492bf4d18f31e558bd0216bcccd2705af4d7 
>   src/tests/containerizer.hpp e05ce0323e032911d46d8682661ffe4463fdc276 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp c15a6fad642474765e4ad1952af6cd9ee937379e 
>   src/tests/containerizer/isolator.hpp 5861b8b8abbba65c499aa57fbf489d0c74414a5b 
>   src/tests/containerizer/launcher.hpp 6567e9663b3b8d143f4bc38421deee7876c19e37 
>   src/tests/containerizer/mock_containerizer.hpp 8700257a9347199ed6e32b8b6b2a58787d68af03 
>   src/tests/containerizer/provisioner_docker_tests.cpp bf56d603fcc1d99f73beca1871be45787fa1640d 
>   src/tests/disk_profile_server.hpp 1a8d2913eaf91b3b839471fe2a600e4bc59ecaed 
>   src/tests/fetcher_tests.cpp f3ea7092635c88b9dddcc2998a4c7350fb56110c 
>   src/tests/http_authentication_tests.cpp 0c2537408aff8b018d9af39f92bbab3ebad938be 
>   src/tests/log_tests.cpp a8980e3676f51d14087f56338ff45de2927ea992 
>   src/tests/mesos.hpp 8142f3f3ab8e4e9230efdcd2e6846d0e0bd293b2 
>   src/tests/mock_csi_plugin.hpp 4642326b65ba7145bc57ac4a56d492697a7501b9 
>   src/tests/mock_docker.hpp 4a2266fb1239cbc96c7df74b997212e3b3b01c75 
>   src/tests/mock_fetcher.hpp fedb737ce42a1c68aa117e3db624c860d8afa7e4 
>   src/tests/mock_registrar.hpp 2a13333e6dce433a4c53ec6639382aacaf0d9dc3 
>   src/tests/mock_slave.hpp 9a74bf35d2cab0a72ba6376392239d8080a49304 
>   src/tests/operation_status_update_manager_tests.cpp e6175700caefb47a95b1edc4ae41755f06781fb4 
>   src/tests/registrar_tests.cpp 81979d78f1348791e28f1afea4ca2999de6362b8 
>   src/tests/uri_fetcher_tests.cpp 260ae9c96f78ee5528cbd61983e1d61bda48c23b 
> 
> 
> Diff: https://reviews.apache.org/r/67950/diff/1/
> 
> 
> Testing
> -------
> 
> make check CXX=clang++ (Fedora 28)
> 
> 
> Thanks,
> 
> James Peach
> 
>