You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Zheng Shao (JIRA)" <ji...@apache.org> on 2010/01/16 03:55:54 UTC
[jira] Created: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
disable SELECT * FROM a JOIN b ON key
-------------------------------------
Key: HIVE-1060
URL: https://issues.apache.org/jira/browse/HIVE-1060
Project: Hadoop Hive
Issue Type: Bug
Reporter: Zheng Shao
In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805217#action_12805217 ]
John Sichi commented on HIVE-1060:
----------------------------------
BTW, there is a standard SQL:200n construct SELECT * FROM a JOIN b USING(key), so we might want to file a followup JIRA for providing the original behavior using the standard (unambiguous) syntax.
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Vikram Chandrasekhar
> Attachments: HIVE-1060.1.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805216#action_12805216 ]
Zheng Shao commented on HIVE-1060:
----------------------------------
One more question:
Can you find out why the follow-on semantic analysis didn't catch this problem?
The column reference should end up with "ambiguous column" since both tables have this column, but apparently it didn't.
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Vikram Chandrasekhar
> Attachments: HIVE-1060.1.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "Vikram Chandrasekhar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikram Chandrasekhar updated HIVE-1060:
---------------------------------------
Attachment: HIVE-1086.2.patch
Added a negative test. The conditional can also be a function, so a simple '=' test won't be sufficient.
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Vikram Chandrasekhar
> Attachments: HIVE-1060.1.patch, HIVE-1086.2.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao reassigned HIVE-1060:
--------------------------------
Assignee: Vikram Chandrasekhar
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Vikram Chandrasekhar
> Attachments: HIVE-1060.1.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "Vikram Chandrasekhar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikram Chandrasekhar updated HIVE-1060:
---------------------------------------
Affects Version/s: 0.6.0
0.5.0
Status: Patch Available (was: Open)
Checks for join condition being just a single un-prefixed column of either primitive or complex type
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Attachments: HIVE-1060.1.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "Vikram Chandrasekhar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikram Chandrasekhar updated HIVE-1060:
---------------------------------------
Attachment: HIVE-1060.1.patch
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Attachments: HIVE-1060.1.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805218#action_12805218 ]
Namit Jain commented on HIVE-1060:
----------------------------------
Can you add a test in negative tests ?
Also, do you think it would be simpler to check for "=" instead of the check you have added.
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Vikram Chandrasekhar
> Attachments: HIVE-1060.1.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HIVE-1060) disable SELECT * FROM a JOIN b ON key
Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zheng Shao updated HIVE-1060:
-----------------------------
Status: Open (was: Patch Available)
> disable SELECT * FROM a JOIN b ON key
> -------------------------------------
>
> Key: HIVE-1060
> URL: https://issues.apache.org/jira/browse/HIVE-1060
> Project: Hadoop Hive
> Issue Type: Bug
> Affects Versions: 0.5.0, 0.6.0
> Reporter: Zheng Shao
> Assignee: Vikram Chandrasekhar
> Attachments: HIVE-1060.1.patch, HIVE-1086.2.patch
>
>
> In some SQL dialect, we support this kind of syntax as a shortcut of "a.key = b.key".
> We should output an error for this. Currently we are allowing this because we might have implicit type conversion from String to Boolean.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.