You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/06 17:37:25 UTC

[GitHub] [kafka] C0urante commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

C0urante commented on pull request #8069:
URL: https://github.com/apache/kafka/pull/8069#issuecomment-624788853


   Thanks for the review, @gharris1727. I've addressed all of your comments with either changes or responses; let me know what you think.
   
   @kkonstantine -- there are a few places with nested callback logic that I've left untouched for now just to avoid inflating the diff, but apart from those, I've replaced construction of anonymous `Runnable` and `Callback` instances with lambda syntax in the `StandaloneHerder` and `DistributedHerder` classes. Tried to strike a balance here; if we want to go further we always can.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org