You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by rc...@apache.org on 2020/05/04 10:01:56 UTC
[james-project] 09/14: [REFACTORING] GetMessagesMethod IntelliJ
warnings
This is an automated email from the ASF dual-hosted git repository.
rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit ea55e5a76a45f8f6d9d840ce1d8aae25a00e4343
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Wed Apr 15 10:24:44 2020 +0700
[REFACTORING] GetMessagesMethod IntelliJ warnings
---
.../org/apache/james/jmap/draft/methods/GetMessagesMethod.java | 8 +-------
.../apache/james/jmap/draft/methods/GetMessagesMethodTest.java | 2 +-
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/GetMessagesMethod.java b/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/GetMessagesMethod.java
index d16367f..2b9a3ab 100644
--- a/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/GetMessagesMethod.java
+++ b/server/protocols/jmap-draft/src/main/java/org/apache/james/jmap/draft/methods/GetMessagesMethod.java
@@ -53,20 +53,14 @@ public class GetMessagesMethod implements Method {
public static final String HEADERS_FILTER = "headersFilter";
private static final String ISSUER = "GetMessagesMethod";
- private static final Logger LOGGER = LoggerFactory.getLogger(GetMessagesMethod.class);
private static final Method.Request.Name METHOD_NAME = Method.Request.name("getMessages");
private static final Method.Response.Name RESPONSE_NAME = Method.Response.name("messages");
private final MetaMessageViewFactory messageViewFactory;
- private final MessageIdManager messageIdManager;
private final MetricFactory metricFactory;
@Inject
- @VisibleForTesting GetMessagesMethod(
- MetaMessageViewFactory messageViewFactory,
- MessageIdManager messageIdManager,
- MetricFactory metricFactory) {
+ @VisibleForTesting GetMessagesMethod(MetaMessageViewFactory messageViewFactory, MetricFactory metricFactory) {
this.messageViewFactory = messageViewFactory;
- this.messageIdManager = messageIdManager;
this.metricFactory = metricFactory;
}
diff --git a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java
index 4103ff3..ce487b4 100644
--- a/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java
+++ b/server/protocols/jmap-draft/src/test/java/org/apache/james/jmap/draft/methods/GetMessagesMethodTest.java
@@ -134,7 +134,7 @@ public class GetMessagesMethodTest {
new MessageHeaderViewFactory(blobManager, messageIdManager),
messageMetadataViewFactory,
messageFastViewFactory);
- testee = new GetMessagesMethod(metaMessageViewFactory, messageIdManager, new DefaultMetricFactory());
+ testee = new GetMessagesMethod(metaMessageViewFactory, new DefaultMetricFactory());
messageContent1 = org.apache.james.mime4j.dom.Message.Builder.of()
.setSubject("message 1 subject")
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org