You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by xkli <gi...@git.apache.org> on 2017/03/20 12:24:57 UTC

[GitHub] incubator-weex pull request #134: * [android] update modify rewrite

GitHub user xkli opened a pull request:

    https://github.com/apache/incubator-weex/pull/134

    * [android] update modify rewrite

    @sospartan 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xkli/incubator-weex 0.12-dev-rewrite

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/134.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #134
    
----
commit f1fc1a30845441e166d998b3e4a5fbe9d5fa2a10
Author: xkli <56...@qq.com>
Date:   2017-03-20T12:24:00Z

    * [android] update modify rewrite

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex pull request #134: * [android] update modify rewrite

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-weex/pull/134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-weex issue #134: * [android] update modify rewrite

Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:

    https://github.com/apache/incubator-weex/pull/134
  
    
    <!--
      0 failure: 
      1 warning:  Potential BREAK C...
      
      
    -->
    
    
    <table>
      <thead>
        <tr>
          <th width="50"></th>
          <th width="100%" data-danger-table="true">Warnings</th>
        </tr>
      </thead>
      <tbody><tr>
          <td>:warning:</td>
          <td>Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/WXSDKInstance.java without metion it in commit message. You'd better add 'break change' in your commit log. </td>
        </tr>
      </tbody>
    </table>
    
    
    
    <p align="right">
      Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
    </p>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---