You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Flink CDC Issue Import (Jira)" <ji...@apache.org> on 2024/03/20 09:24:00 UTC
[jira] [Created] (FLINK-34816) Allow custom Configurations for ConnectionPool
Flink CDC Issue Import created FLINK-34816:
----------------------------------------------
Summary: Allow custom Configurations for ConnectionPool
Key: FLINK-34816
URL: https://issues.apache.org/jira/browse/FLINK-34816
Project: Flink
Issue Type: Improvement
Components: Flink CDC
Reporter: Flink CDC Issue Import
### Search before asking
- [X] I searched in the [issues|https://github.com/ververica/flink-cdc-connectors/issues] and found nothing similar.
### Motivation
In https://github.com/ververica/flink-cdc-connectors/pull/534, we introduced Hikari connection pool to reduce connection usage.
Then, we added some predefined configurations like maximumPoolSize = 20, minimumIdle = 1, connectionTimeout = 30s.
Howerver, there are still some frequently-used configurations that we haven't allow user to set, as [configurations|https://github.com/brettwooldridge/HikariCP#frequently-used] showed, which may be useful like `keepaliveTime`.
It would be better to allow user to add custom pool configurations based on their condition, like what debezium.* and [jdbc.properties.*|https://github.com/ververica/flink-cdc-connectors/pull/921] do.
### Solution
allow custom pool configurations like `hikari.*`, and add them to `HikariConfig`
### Alternatives
_No response_
### Anything else?
Requires compatibility with previous parameters like `connection.pool.size` and `connect.timeout`, and jdbcUrlădriverClassName could not be modified too.
### Are you willing to submit a PR?
- [X] I'm willing to submit a PR!
---------------- Imported from GitHub ----------------
Url: https://github.com/apache/flink-cdc/issues/2509
Created by: [lvyanquan|https://github.com/lvyanquan]
Labels: enhancement,
Created at: Wed Sep 20 11:51:23 CST 2023
State: open
--
This message was sent by Atlassian Jira
(v8.20.10#820010)