You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by Dmitriy Ryaboy <dv...@gmail.com> on 2011/07/04 00:44:32 UTC
Reviewboard question
How do you specify the base directory when uploading a patch?
I generated a patch via "svn diff" from repository root, and neither
"." nor "./" nor "/" nor any other variant I can think of works -- I
keep getting RB errors along the lines of "The file
"/pig/test/org/apache/pig/test/TestPigServer.java" (revision 1142512)
was not found in the repository"
D
Re: Reviewboard question
Posted by Daniel Dai <da...@hortonworks.com>.
Sure, I will review.
Thanks
Daniel
On Sun, Jul 3, 2011 at 11:47 PM, Dmitriy Ryaboy <dv...@gmail.com> wrote:
> Ah, that makes sense.
>
> Updated the review, think you can take a look?
> https://reviews.apache.org/r/976
>
> D
>
> On Sun, Jul 3, 2011 at 8:43 PM, Daniel Dai <da...@hortonworks.com> wrote:
> > It is the svn path, eg: http://svn.apache.org/repos/asf/pig/trunk.
> Review
> > board also recognize shortcut such as trunk, or branches/branch-0.x.
> >
> > Daniel
> >
> > On Sun, Jul 3, 2011 at 5:44 PM, Dmitriy Ryaboy <dv...@gmail.com>
> wrote:
> >
> >> How do you specify the base directory when uploading a patch?
> >> I generated a patch via "svn diff" from repository root, and neither
> >> "." nor "./" nor "/" nor any other variant I can think of works -- I
> >> keep getting RB errors along the lines of "The file
> >> "/pig/test/org/apache/pig/test/TestPigServer.java" (revision 1142512)
> >> was not found in the repository"
> >>
> >> D
> >>
> >
>
Re: Reviewboard question
Posted by Dmitriy Ryaboy <dv...@gmail.com>.
Ah, that makes sense.
Updated the review, think you can take a look?
https://reviews.apache.org/r/976
D
On Sun, Jul 3, 2011 at 8:43 PM, Daniel Dai <da...@hortonworks.com> wrote:
> It is the svn path, eg: http://svn.apache.org/repos/asf/pig/trunk. Review
> board also recognize shortcut such as trunk, or branches/branch-0.x.
>
> Daniel
>
> On Sun, Jul 3, 2011 at 5:44 PM, Dmitriy Ryaboy <dv...@gmail.com> wrote:
>
>> How do you specify the base directory when uploading a patch?
>> I generated a patch via "svn diff" from repository root, and neither
>> "." nor "./" nor "/" nor any other variant I can think of works -- I
>> keep getting RB errors along the lines of "The file
>> "/pig/test/org/apache/pig/test/TestPigServer.java" (revision 1142512)
>> was not found in the repository"
>>
>> D
>>
>
Re: Reviewboard question
Posted by Daniel Dai <da...@hortonworks.com>.
It is the svn path, eg: http://svn.apache.org/repos/asf/pig/trunk. Review
board also recognize shortcut such as trunk, or branches/branch-0.x.
Daniel
On Sun, Jul 3, 2011 at 5:44 PM, Dmitriy Ryaboy <dv...@gmail.com> wrote:
> How do you specify the base directory when uploading a patch?
> I generated a patch via "svn diff" from repository root, and neither
> "." nor "./" nor "/" nor any other variant I can think of works -- I
> keep getting RB errors along the lines of "The file
> "/pig/test/org/apache/pig/test/TestPigServer.java" (revision 1142512)
> was not found in the repository"
>
> D
>