You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/02 02:13:34 UTC

[GitHub] [incubator-tvm] FrozenGene opened a new issue #5215: [AutoTVM] AutoTVM incorrect measurement

FrozenGene opened a new issue #5215: [AutoTVM] AutoTVM incorrect measurement
URL: https://github.com/apache/incubator-tvm/issues/5215
 
 
   Our AutoTVM use `debug_skip_region` to skip our precompute stage (like precompute kernel). However, `debug_skip_region` can not reflect practical running, which just only create empty tensor for it. Empty tensor will make AutoTVM record the performance incorrect. This condition will become worse like Winograd. In Winograd, our weight shape will be changed from (KH, KW, CO, CI) to (alpha, alpha, CO, CI). Alpha equals to `tile_size + KH - 1`. If tile_size is 4 (KH is 3), then alpha is 6. So to avoid this issue, we should avoid using `debug_skip_region` in all platforms of AutoTVM template and use the technique like this PR: https://github.com/apache/incubator-tvm/pull/5200.
   
   Open this issue to track this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] FrozenGene commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-617256430


   > @FrozenGene what is the status of this issue?
   
   This issue wants to track all template of using `debug_skip_region`(like arm / cuda and so on). Currently, we only fix intel conv2d. I think I should list the target we should fix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-617232476


   @FrozenGene what is the status of this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-678336776


   OK, we will leave the issue open then,  please remember to update it as we add more improvements.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] FrozenGene commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-676861307


   Currently, as listed, we have completed ` Intel CPU / ARM CPU / Bifrost / Mali ` (thanks to community's help) implementation except cuda (some progress we have done like conv2d_nhwc_winograd / conv3d_winograd when we review related prs) / intel graphics.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] FrozenGene commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
FrozenGene commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-636300190


   > @FrozenGene In #5200 we discussed another source of autotvm inaccurate measurement due to empty input tensor. Do we have a timeline to fix that?
   
   @kevinthesun FYI. We are rebasing our code based on the laster master. After completing it, this fix will be brought in.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-676853131


   ping @FrozenGene 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] tqchen commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-661491112


   @FrozenGene please update the status of this issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-tvm] kevinthesun commented on issue #5215: [AutoTVM] AutoTVM incorrect measurement

Posted by GitBox <gi...@apache.org>.
kevinthesun commented on issue #5215:
URL: https://github.com/apache/incubator-tvm/issues/5215#issuecomment-626050953


   @FrozenGene In https://github.com/apache/incubator-tvm/pull/5200 we discussed another source of autotvm inaccurate measurement due to empty input tensor. Do we have a timeline to fix that?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org