You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/22 11:18:27 UTC

[GitHub] [dubbo-go-hessian2] wongoo opened a new pull request #251: merge fo 1.8.1

wongoo opened a new pull request #251:
URL: https://github.com/apache/dubbo-go-hessian2/pull/251


   merge fo 1.8.1


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] AlexStocks commented on pull request #251: merge fo 1.8.1

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #251:
URL: https://github.com/apache/dubbo-go-hessian2/pull/251#issuecomment-749576185


   @wongoo pls check github action license-check failure


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #251: merge fo 1.8.1

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #251:
URL: https://github.com/apache/dubbo-go-hessian2/pull/251#issuecomment-749492134


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=h1) Report
   > Merging [#251](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=desc) (e2494da) into [1.8](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/07e93979195dcefa9e5c590409cc6d9886cec7cb?el=desc) (07e9397) will **increase** coverage by `0.08%`.
   > The diff coverage is `64.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.8     #251      +/-   ##
   ==========================================
   + Coverage   66.10%   66.19%   +0.08%     
   ==========================================
     Files          25       25              
     Lines        2785     2801      +16     
   ==========================================
   + Hits         1841     1854      +13     
   - Misses        716      718       +2     
   - Partials      228      229       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [long.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bG9uZy5nbw==) | `57.83% <0.00%> (ø)` | |
   | [hessian.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-aGVzc2lhbi5nbw==) | `46.07% <25.00%> (ø)` | |
   | [map.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bWFwLmdv) | `54.87% <33.33%> (ø)` | |
   | [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `64.39% <33.33%> (ø)` | |
   | [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `56.70% <60.00%> (-0.57%)` | :arrow_down: |
   | [date.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-ZGF0ZS5nbw==) | `68.18% <66.66%> (+1.51%)` | :arrow_up: |
   | [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `74.00% <100.00%> (+0.26%)` | :arrow_up: |
   | [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bGlzdC5nbw==) | `84.00% <100.00%> (ø)` | |
   | [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `65.34% <100.00%> (ø)` | |
   | [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `59.40% <100.00%> (+0.61%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=footer). Last update [07e9397...e2494da](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #251: merge fo 1.8.1

Posted by GitBox <gi...@apache.org>.
wongoo commented on pull request #251:
URL: https://github.com/apache/dubbo-go-hessian2/pull/251#issuecomment-751179554


   > @wongoo pls check github action license-check failure
   
   it's only failed for pull_request_target, which already fixed in main branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] codecov-io commented on pull request #251: merge fo 1.8.1

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #251:
URL: https://github.com/apache/dubbo-go-hessian2/pull/251#issuecomment-749492134


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=h1) Report
   > Merging [#251](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=desc) (4014d7e) into [1.8](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/07e93979195dcefa9e5c590409cc6d9886cec7cb?el=desc) (07e9397) will **increase** coverage by `0.08%`.
   > The diff coverage is `64.28%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.8     #251      +/-   ##
   ==========================================
   + Coverage   66.10%   66.19%   +0.08%     
   ==========================================
     Files          25       25              
     Lines        2785     2801      +16     
   ==========================================
   + Hits         1841     1854      +13     
   - Misses        716      718       +2     
   - Partials      228      229       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [long.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bG9uZy5nbw==) | `57.83% <0.00%> (ø)` | |
   | [hessian.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-aGVzc2lhbi5nbw==) | `46.07% <25.00%> (ø)` | |
   | [map.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bWFwLmdv) | `54.87% <33.33%> (ø)` | |
   | [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `64.39% <33.33%> (ø)` | |
   | [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `56.70% <60.00%> (-0.57%)` | :arrow_down: |
   | [date.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-ZGF0ZS5nbw==) | `68.18% <66.66%> (+1.51%)` | :arrow_up: |
   | [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `74.00% <100.00%> (+0.26%)` | :arrow_up: |
   | [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bGlzdC5nbw==) | `84.00% <100.00%> (ø)` | |
   | [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `65.34% <100.00%> (ø)` | |
   | [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `59.40% <100.00%> (+0.61%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=footer). Last update [07e9397...4014d7e](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] codecov-io edited a comment on pull request #251: merge fo 1.8.1

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #251:
URL: https://github.com/apache/dubbo-go-hessian2/pull/251#issuecomment-749492134


   # [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=h1) Report
   > Merging [#251](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=desc) (83d9f69) into [1.8](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/07e93979195dcefa9e5c590409cc6d9886cec7cb?el=desc) (07e9397) will **increase** coverage by `1.51%`.
   > The diff coverage is `74.62%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/graphs/tree.svg?width=650&height=150&src=pr&token=Yh82j7lS1W)](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.8     #251      +/-   ##
   ==========================================
   + Coverage   66.10%   67.61%   +1.51%     
   ==========================================
     Files          25       25              
     Lines        2785     2671     -114     
   ==========================================
   - Hits         1841     1806      -35     
   + Misses        716      644      -72     
   + Partials      228      221       -7     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [long.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bG9uZy5nbw==) | `57.83% <0.00%> (ø)` | |
   | [hessian.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-aGVzc2lhbi5nbw==) | `46.07% <25.00%> (ø)` | |
   | [map.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bWFwLmdv) | `54.87% <33.33%> (ø)` | |
   | [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `64.39% <33.33%> (ø)` | |
   | [date.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-ZGF0ZS5nbw==) | `68.18% <66.66%> (+1.51%)` | :arrow_up: |
   | [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `70.70% <79.54%> (+13.43%)` | :arrow_up: |
   | [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `72.00% <100.00%> (-1.74%)` | :arrow_down: |
   | [list.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-bGlzdC5nbw==) | `84.00% <100.00%> (ø)` | |
   | [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `65.34% <100.00%> (ø)` | |
   | [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `59.40% <100.00%> (+0.61%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=footer). Last update [07e9397...83d9f69](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/251?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go-hessian2] AlexStocks merged pull request #251: merge fo 1.8.1

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #251:
URL: https://github.com/apache/dubbo-go-hessian2/pull/251


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org