You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/01/19 06:09:41 UTC
[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1250:
[HUDI-557] Additional job for supporting multiple version docs
lamber-ken opened a new pull request #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250
## What is the purpose of the pull request
Additional job for supporting multiple version docs.
## Brief change log
- *Additional job for supporting multiple version docs.*
## Verify this pull request
This pull request is web doc cleanup without any test coverage.
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on a change in pull request
#1250: [HUDI-557] Additional job for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on a change in pull request #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#discussion_r368334483
##########
File path: docs/_docs/3_2_docs_versions.md
##########
@@ -9,7 +9,7 @@ last_modified_at: 2019-12-30T15:59:57-04:00
<tbody>
{% for d in site.previous_docs %}
<tr>
- <th>{{ d.version }}</th>
+ <th style="background-color: white !important;">{{ d.version }}</th>
Review comment:
From my side, the versions seems stick together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1250: [HUDI-557]
Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576096431
>I think we need to told user which version of docs they are visiting
this is valid. I still think we need a different mechanism than a banner for this. We can check out other sites for inspiration
> guide users to use the latest version as much as possible.
Sure. but we should not be doing this via a banner IMO.. Lets get rid of the banner and we can land this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1250: [HUDI-557]
Additional job for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-575976889
## Main things:
- Add versions to `previous_docs`.
- Add `0.5.0_cn_docs` in `navigation.yml` file.
- Support out of data version tip.
- Quick review, https://lamber-ken.github.io
<br>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1250: [HUDI-557]
Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576098873
> > I think we need to told user which version of docs they are visiting
>
> this is valid. I still think we need a different mechanism than a banner for this. We can check out other sites for inspiration
>
> > guide users to use the latest version as much as possible.
>
> Sure. but we should not be doing this via a banner IMO.. Lets get rid of the banner and we can land this?
Got it, I removed the banner currently. When I find a better way, I will talk with you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1250:
[HUDI-557] Additional job for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576062938
> This LGTM overall.. have you tested this with the current site? should we also refresh the content
Yes, I generate the site and sync to https://lamber-ken.github.io/docs/0.5.0-quick-start-guide.html
When we reach an agreement, I will generate the content. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar merged pull request #1250:
[HUDI-557] Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
vinothchandar merged pull request #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1250:
[HUDI-557] Additional job for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576062938
> This LGTM overall.. have you tested this with the current site? should we also refresh the content
Yes, I generate the site and sync to https://lamber-ken.github.io/docs/0.5.0-quick-start-guide.html
When we reach an agreement, I will generate the content. It is easy to review the pr currently. 😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1250: [HUDI-557]
Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576113149
> Thanks @lamber-ken !
You're welcome. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on a change in pull
request #1250: [HUDI-557] Additional job for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#discussion_r368333402
##########
File path: docs/_docs/3_2_docs_versions.md
##########
@@ -9,7 +9,7 @@ last_modified_at: 2019-12-30T15:59:57-04:00
<tbody>
{% for d in site.previous_docs %}
<tr>
- <th>{{ d.version }}</th>
+ <th style="background-color: white !important;">{{ d.version }}</th>
Review comment:
why this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1250: [HUDI-557]
Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576107876
Thanks @lamber-ken !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1250: [HUDI-557]
Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576068152
How about this style :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1250: [HUDI-557]
Additional job for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576062938
> This LGTM overall.. have you tested this with the current site? should we also refresh the content
Yes, I generate the site and sync to https://lamber-ken.github.io/docs/0.5.0-quick-start-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken commented on issue #1250: [HUDI-557]
Additional job for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on issue #1250: [HUDI-557] Additional job for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576062580
> Can we remove the "out of date" warning.. I feel its not necessary.. And also depending on situation, using latest may not be the right thing always.. for e.g if the user is still on 2.2
I think we need to told user which version of docs they are visiting, and guide users to use the latest version as much as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar edited a comment on issue #1250:
[HUDI-557] Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
vinothchandar edited a comment on issue #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576096431
>I think we need to told user which version of docs they are visiting
this is valid. I still think we need a different mechanism than a banner for this. We can check out other sites for inspiration
> guide users to use the latest version as much as possible.
Sure. but we should not be doing this via a banner IMO.. Lets get rid of the banner and we can land this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1250:
[HUDI-557] Additional work for supporting multiple version docs
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on issue #1250: [HUDI-557] Additional work for supporting multiple version docs
URL: https://github.com/apache/incubator-hudi/pull/1250#issuecomment-576068152
Hi @vinothchandar, how about this style :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services