You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/14 19:58:40 UTC

[GitHub] [airflow] lewis-anderson53 commented on issue #10549: option to disable "lots of circles" in error page

lewis-anderson53 commented on issue #10549:
URL: https://github.com/apache/airflow/issues/10549#issuecomment-798969507


   I'm looking to make my first contribution to the project, I've just been looking at how this is rendered and I've got a pretty good idea how we could implement this.
   
   If the `airflow.cfg` file contains something like `circles_dynamic`, we could fetch the value when rendering the circles HTML template [here](https://github.com/apache/airflow/blob/4cde47b339d5ab5e4ebccfb22962ccbfc4c5457e/airflow/www/views.py#L368) where the default fallback value is `True`, meaning this SVG will by default behave as it currently does.
   
   In the [circles.html](https://github.com/apache/airflow/blob/4cde47b339d5ab5e4ebccfb22962ccbfc4c5457e/airflow/www/templates/airflow/circles.html#L37) template, we could use Jinja to determine whether or not to load the default `circles.js` or some new file, called `circles_static.js`, which simply draws the circles once, without redrawing them constantly, which I understand to be the root cause of this issue right @jameswynn ?
   
   Open to suggestions, this is just the first method that came to my mind!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org