[GitHub] spark pull request #18029: [SPARK-20168] [DStream] Add changes to use kinesi...

[brkyvz <gi...@git.apache.org>]

Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18029#discussion_r143849634
  
    --- Diff: external/kinesis-asl/src/main/java/org/apache/spark/streaming/kinesis/KinesisInitialPosition.java ---
    @@ -0,0 +1,53 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.streaming.kinesis;
    +
    +import java.util.Date;
    +
    +/**
    + * A java wrapper for org.apache.spark.streaming.kinesis.InitialPosition
    + * to expose the corresponding scala objects for InitialPositionInStream.
    + * The functions are intentionally Upper cased to appear like classes for
    + * usage in Java classes.
    + */
    +public class KinesisInitialPosition {
    +
    +    /**
    +     * Returns instance of AtTimestamp with InitialPositionInStream.LATEST.
    +     * @return
    +     */
    +    public static InitialPosition Latest() {
    +        return InitialPosition$.MODULE$.latest();
    +    }
    +
    +    /**
    +     * Returns instance of AtTimestamp with InitialPositionInStream.TRIM_HORIZON.
    +     * @return
    +     */
    +    public static InitialPosition TrimHorizon() {
    +        return InitialPosition$.MODULE$.trimHorizon();
    --- End diff --
    
    Can you instead return `TrimHorizon$.MODULE$`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org