[jira] [Commented] (SLING-5315) rescheduled failed jobs increment queued jobs counter

["Carsten Ziegeler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15022080#comment-15022080 ] 

Carsten Ziegeler commented on SLING-5315:
-----------------------------------------

The job queue has been changed from a version which holds all jobs in memory to a queue which just holds part of it in memory. The stats implementation seems not be adjusted to this.

> rescheduled failed jobs increment queued jobs counter
> -----------------------------------------------------
>
>                 Key: SLING-5315
>                 URL: https://issues.apache.org/jira/browse/SLING-5315
>             Project: Sling
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: Event 3.7.6
>         Environment: seen in sling.event 3.7.6
>            Reporter: Stefan Egli
>            Assignee: Carsten Ziegeler
>             Fix For: Event 4.0.0
>
>
> When a job fails and is rescheduled (eg in 60sec), then the statistics are skewed:
> * a job start calls {{stats.addActive}} which decrements {{queuedJobs}}
> * for a failed job, {{queue.finishJob}} indirectly calls {{stats.failedJob}} which increments {{queuedJobs}} again
> * then the job is marked for rescheduling in eg 60sec
> * then upon rescheduling in {{queue.requeue}}, indirectly {{stats.incQueued}} is called, which increments {{queuedJobs}} as well
> With the result that the {{queuedJobs}} counter is incremented each time a job fails - even though there are not really more jobs in the queue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)