You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/17 02:43:49 UTC

[GitHub] [pulsar] seeday opened a new pull request #8076: Update #! in shell scripts

seeday opened a new pull request #8076:
URL: https://github.com/apache/pulsar/pull/8076

<!--
### Contribution Checklist

- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.

- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

- Each pull request should address only one issue, not mix up code from multiple issues.

- Each commit in the pull request has a meaningful commit message

- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.

**(The sections below can be removed for hotfixes of typos)**
-->

### Motivation

Some new distributions like nix and guix have stressed the definition of posix compliance and do not provide `/bin/bash`, breaking pulsar builds for these distros. This PR applies the most straightforward fix, as `/usr/bin/env` is posix.

Note for those searching in the future: there are still issues with nix builds relating to [this ridiculousness](https://discourse.nixos.org/t/runtime-alternative-to-patchelf-set-interpreter/3539), but that's truly a nix issue, not pulsar.

### Modifications

`fd -e .sh -x sed -i 's/#!\/bin\/bash/#!\/usr\/bin\/env bash/'`

### Verifying this change

- [ ] Make sure that the change passes the CI checks.

This change is a trivial rework / **code cleanup** without any test coverage.

### Does this pull request potentially affect one of the following parts:

*If `yes` was chosen, please highlight the changes*

- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API: (yes / **no**)
- The schema: (yes / **no** / don't know)
- The default values of configurations: (yes / **no**)
- The wire protocol: (yes / **no**)
- The rest endpoints: (yes / **no**)
- The admin cli options: (yes / **no**)
- Anything that affects deployment: (yes / **no**/ don't know)

### Documentation

- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org