[jira] [Commented] (MESOS-870) Slave http endpoint can crash the slave when no master is detected.

["Benjamin Mahler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13840815#comment-13840815 ] 

Benjamin Mahler commented on MESOS-870:
---------------------------------------

https://reviews.apache.org/r/16072/

> Slave http endpoint can crash the slave when no master is detected.
> -------------------------------------------------------------------
>
>                 Key: MESOS-870
>                 URL: https://issues.apache.org/jira/browse/MESOS-870
>             Project: Mesos
>          Issue Type: Bug
>          Components: slave
>    Affects Versions: 0.16.0
>            Reporter: Benjamin Mahler
>            Assignee: Benjamin Mahler
>             Fix For: 0.16.0
>
>
> This code assumes the master Result is not none:
> Future<Response> Slave::Http::state(const Request& request)
> {
>   Try<string> masterHostname = net::getHostname(slave.master.get().ip); // XXX Need to check slave.master first.
>   if (masterHostname.isSome()) {
>     object.values["master_hostname"] = masterHostname.get();
>   }
>   ...
> }



--
This message was sent by Atlassian JIRA
(v6.1#6144)