You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/07/22 09:43:25 UTC

[GitHub] [activemq-artemis] gtully commented on a diff in pull request #4154: ARTEMIS-3901 Fix artemis perf client --durable fails on exception

gtully commented on code in PR #4154:
URL: https://github.com/apache/activemq-artemis/pull/4154#discussion_r927483547


##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/messages/perf/PerfClientCommand.java:
##########
@@ -131,6 +134,7 @@ protected void onExecuteBenchmark(final ConnectionFactory producerConnectionFact
          .setTimeProvider(() -> TimeUnit.NANOSECONDS.toMicros(System.nanoTime()))
          .setCanDelayMessageCount(true)
          .setSharedSubscription(sharedSubscription)
+         .setClientID(UUID.randomUUID().toString())

Review Comment:
   this seems odd, maybe durableSubscription boolean needs to be an identity in the form of a string. If the generated uuid is the identity of the subscription, then it won't be possible to access those messages on a second attempt.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org