You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Jan Piotrowski (Sujan) (JIRA)" <ji...@apache.org> on 2018/08/26 13:16:00 UTC
[jira] [Comment Edited] (CB-13564) Multiple edit-config items for
Info.plist causing error
[ https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16592894#comment-16592894 ]
Jan Piotrowski (Sujan) edited comment on CB-13564 at 8/26/18 1:15 PM:
----------------------------------------------------------------------
[~bytenik] I am unfortunately not an real Cordova _developer_ - I better leave the actual coding to people that can do that a lot better.
But my suggestion:
If you want to push this forward you a) create a PR with the suggested changes, just mention that it has to be understood better and investigated before mergin and b) best create a Github repo with a reproduction (maybe 2 because from the previous comment it seems a plugin is needed as well). But that both existing, enough people should be able to reproduce, understand and dissect it so that this should move forward.
was (Author: sujan12):
[~bytenik] I am unfortunately not an real Cordova developer - I better leave the actual coding to people that can.
But my suggestion:
If you want to push this forward you a) create a PR with the suggested changes, just mention that it has to be understood better and investigated before mergin and b) best create a Github repo with a reproduction (maybe 2 because from the previous comment it seems a plugin is needed as well). But that both existing, enough people should be able to reproduce, understand and dissect it so that this should move forward.
> Multiple edit-config items for Info.plist causing error
> -------------------------------------------------------
>
> Key: CB-13564
> URL: https://issues.apache.org/jira/browse/CB-13564
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
> Affects Versions: 7.1.0
> Reporter: Tom Bell
> Priority: Major
>
> I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3.0.0, I've got the following
> working:
> {code:xml}
> <edit-config file="*-Info.plist" mode="merge" target="NSContactsUsageDescription">
> <string>We require permission to access your contacts so you can import contacts into [redacted]</string>
> </edit-config>
> {code}
> However when I decided to move some stuff from an `after_prepare` hook script, to use edit-config, it fails with an error `doc.find is not a function`
> {code:xml}
> <edit-config file="*-Info.plist" mode="merge" target="NSContactsUsageDescription">
> <string>We require permission to access your contacts so you can import contacts into [redacted]</string>
> </edit-config>
> <edit-config file="*-Info.plist" mode="merge" target="UIStatusBarStyle">
> <string>UIStatusBarStyleLightContent</string>
> </edit-config>
> {code}
> If I take out the additional `<edit-config>` everything works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org