You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kumarvishal09 <gi...@git.apache.org> on 2018/01/16 09:24:37 UTC
[GitHub] carbondata pull request #1811: [CARBONDATA-2034]Fixed Query performance issu...
GitHub user kumarvishal09 opened a pull request:
https://github.com/apache/carbondata/pull/1811
[CARBONDATA-2034]Fixed Query performance issue
**Problem:** Dictionary loading is taking more time in executor side when number of nodes is high.
**Solution**: During query no need to load non complex dimension dictionary. Dictionary decoder will take care of loading and decoding the dictionary column
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kumarvishal09/incubator-carbondata master_DictionaryLoadingIssue
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1811.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1811
----
commit eb11a0f8a6ed1821eaf0b87e0336b2c56a39bf8d
Author: kumarvishal <ku...@...>
Date: 2018-01-16T09:07:25Z
Fixed Query performance issue
----
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1811
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2943/
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1811
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2915/
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1811
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2871/
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1811
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1638/
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1811
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1594/
---
[GitHub] carbondata pull request #1811: [CARBONDATA-2034]Fixed Query performance issu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1811
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1811
retest this please
---
[GitHub] carbondata pull request #1811: [CARBONDATA-2034]Fixed Query performance issu...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1811#discussion_r162040412
--- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/util/QueryUtil.java ---
@@ -294,20 +292,19 @@ private static void addChildrenBlockIndex(Set<Integer> blockIndexes, CarbonDimen
// write encoding dictionary
if (CarbonUtil.hasEncoding(encodingList, Encoding.DICTIONARY) && !CarbonUtil
.hasEncoding(encodingList, Encoding.DIRECT_DICTIONARY) && !CarbonUtil
- .hasEncoding(encodingList, Encoding.IMPLICIT)) {
-
- if (queryDimensions.get(i).getDimension().getNumberOfChild() == 0) {
- dictionaryDimensionFromQuery.add(queryDimensions.get(i).getDimension().getColumnId());
- }
- if (queryDimensions.get(i).getDimension().getNumberOfChild() > 0) {
- getChildDimensionDictionaryDetail(queryDimensions.get(i).getDimension(),
- dictionaryDimensionFromQuery);
- }
+ .hasEncoding(encodingList, Encoding.IMPLICIT)
+ && queryDimensions.get(i).getDimension().getNumberOfChild() > 0) {
--- End diff --
Better use isComplex()
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1811
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1628/
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1811
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2829/
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1811
LGTM
---
[GitHub] carbondata issue #1811: [CARBONDATA-2034]Fixed Query performance issue
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1811
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2859/
---