You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by yi...@apache.org on 2022/04/06 01:21:40 UTC
[arrow] branch master updated: MINOR: [C++] Properly skip nested fork test on MacOS
This is an automated email from the ASF dual-hosted git repository.
yibocai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new e047c9a6c9 MINOR: [C++] Properly skip nested fork test on MacOS
e047c9a6c9 is described below
commit e047c9a6c9df565b86143036cc6bab26d3a59306
Author: Weston Pace <we...@gmail.com>
AuthorDate: Wed Apr 6 01:21:26 2022 +0000
MINOR: [C++] Properly skip nested fork test on MacOS
I had inverted the `ifdef` logic when I first added the skip
Closes #12801 from westonpace/bugfix/MINOR--ifdef-in-thread-utility-test-reversed
Authored-by: Weston Pace <we...@gmail.com>
Signed-off-by: Yibo Cai <yi...@arm.com>
---
cpp/src/arrow/util/thread_pool_test.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpp/src/arrow/util/thread_pool_test.cc b/cpp/src/arrow/util/thread_pool_test.cc
index 219ba9ee9e..b61e964a19 100644
--- a/cpp/src/arrow/util/thread_pool_test.cc
+++ b/cpp/src/arrow/util/thread_pool_test.cc
@@ -858,7 +858,7 @@ TEST_F(TestThreadPoolForkSafety, MultipleChildThreads) {
TEST_F(TestThreadPoolForkSafety, NestedChild) {
{
-#ifndef __APPLE__
+#ifdef __APPLE__
GTEST_SKIP() << "Nested fork is not supported on macos";
#endif
auto pool = this->MakeThreadPool(3);