You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by "Santiago Gala (JIRA)" <je...@portals.apache.org> on 2005/08/23 16:02:08 UTC

[jira] Created: (JS2-347) a portal cannot mix different layout decorations w/o problems

a portal cannot mix different layout decorations w/o problems
-------------------------------------------------------------

         Key: JS2-347
         URL: http://issues.apache.org/jira/browse/JS2-347
     Project: Jetspeed 2
        Type: Bug
  Components: Aggregation  
    Versions: 2.0-M4    
    Reporter: Santiago Gala


While testing the changes in the content server, Juan and myself detected that
one of the css included in the page, and all the images, have the same name for every decorator. 
Namely content/css/styles.css

This produces strange interactions with caching whenever there are fragments
using two different layout decorations in the same page, or the user switches pages.

The icons and styles are taken apparently randomly from both stylesheets, which
plays havoc with the decoration.

It looks like a solution for this would be to have the decoration name in the resource,
like: 
 now: content/images/edit.gif -> content/THEME/images/edit.gif
 now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css

Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Updated: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Santiago Gala (JIRA)" <je...@portals.apache.org>.
     [ http://issues.apache.org/jira/browse/JS2-347?page=all ]

Santiago Gala updated JS2-347:
------------------------------

    Attachment: content.patch

This is how far I arrived, Scott, just in case it saves some time there.

It was working for the css generation. images and/or scripts and other content is missing and trickier, specially the img src of the action gifs.

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala
>  Attachments: content.patch
>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Michael Lipp (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12324523 ] 

Michael Lipp commented on JS2-347:
----------------------------------

I think my problem is related with this. Currently, the error, info etc. icons are not displayed. The styles.css references them as e.g. "url(content/tigris/images/icon_info_sml.gif)". When I debug, I find that SimpleContentLocator evaluates a real path that contains tigris twice (".../tigris/tigris/..."). And of course the icons are not found. Is this related to the issue dicussed here? Or should I open a new issue?

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala
>  Attachments: content.patch
>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Scott T Weaver (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12319912 ] 

Scott T Weaver commented on JS2-347:
------------------------------------

I am currently working on a possible solution for this right now.  Give me a day or two and I should be able to tell whether or not we can make this work.

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala

>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Randy Watler (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12319908 ] 

Randy Watler commented on JS2-347:
----------------------------------

Ate, DST, and myself all voted +1 on the theme name in the content url approach to solving this issue. We would ideally like to add the feature in a way that existing decorators work unchanged, (if at all possible), providing there is only one decorator and/or assets have unique file names.


> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala

>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Santiago Gala (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12319917 ] 

Santiago Gala commented on JS2-347:
-----------------------------------

I forgot to say that this requires renaming of portlet/html/THEME/css/styles.css to -> portlet-styles.css, which actually looks like a good idea. I didn't change the styles.css in layout to layout-styles.css, though it looks like a good idea to lower the confusion levels. :-)

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala
>  Attachments: content.patch
>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Santiago Gala (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12356493 ] 

Santiago Gala commented on JS2-347:
-----------------------------------

Don't know how the hell one can change the fix release of a jira bug, but I'm -1 on releasing 2.0 without this one fixed. 

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala
>  Attachments: content.patch
>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Santiago Gala (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12319909 ] 

Santiago Gala commented on JS2-347:
-----------------------------------

I had a look into implementing this, and couldn't make it work.

I'm thinking that trying to outsmart tomcat (or other http server like apache) is not exactly a good idea,
and I can't find benefits that can't be reaped by a URI scheme that includes the theme name in it.

for instance, decorations' resources could go under:

webapps/content/THEME/images css scripts, and we would just use a conventional static webapp
to serve them.

for decorations, a simple copy of the content skipping declared templates would be enough to get us going,
and tomcat would take care of those resources, with all the benefits of a standard implementation of
HTTP/1.1



> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala

>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Updated: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "David Sean Taylor (JIRA)" <je...@portals.apache.org>.
     [ http://issues.apache.org/jira/browse/JS2-347?page=all ]

David Sean Taylor updated JS2-347:
----------------------------------

    Fix Version: 2.0-FINAL
        Version: 2.0-FINAL
                     (was: 2.0-M4)
      Assign To: Scott T Weaver

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-FINAL
>     Reporter: Santiago Gala
>     Assignee: Scott T Weaver
>      Fix For: 2.0-FINAL
>  Attachments: content.patch
>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Scott T Weaver (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12319994 ] 

Scott T Weaver commented on JS2-347:
------------------------------------

I like the naming policy.  It does make things much clearer for those looking at htings for the first time.

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala
>  Attachments: content.patch
>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Commented: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Scott T Weaver (JIRA)" <je...@portals.apache.org>.
    [ http://issues.apache.org/jira/browse/JS2-347?page=comments#action_12319713 ] 

Scott T Weaver commented on JS2-347:
------------------------------------

Santiago,

This a bug.  Though I think this has always been true as the last batch of content server fixes only targeted dealing with cache controls for browsers correctly and did not touch the resource resolution code.  This has probably been an issue since the advent of the content server and could probably be solved by correctly "namespacing" the the css's like you suggest.

When I first put together the content server, there was no support for nested layouts and hence no need to worry about this isssue.  Now that we have nested layouts, we need to revist the way we are doing things.

Regards,
-Scott

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug
>   Components: Aggregation
>     Versions: 2.0-M4
>     Reporter: Santiago Gala

>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org


[jira] Closed: (JS2-347) a portal cannot mix different layout decorations w/o problems

Posted by "Ate Douma (JIRA)" <je...@portals.apache.org>.
     [ http://issues.apache.org/jira/browse/JS2-347?page=all ]
     
Ate Douma closed JS2-347:
-------------------------

    Resolution: Fixed

This one has been fixed long time ago.

> a portal cannot mix different layout decorations w/o problems
> -------------------------------------------------------------
>
>          Key: JS2-347
>          URL: http://issues.apache.org/jira/browse/JS2-347
>      Project: Jetspeed 2
>         Type: Bug

>   Components: Aggregation
>     Versions: 2.0-FINAL
>     Reporter: Santiago Gala
>     Assignee: Scott T Weaver
>      Fix For: 2.0-FINAL
>  Attachments: content.patch
>
> While testing the changes in the content server, Juan and myself detected that
> one of the css included in the page, and all the images, have the same name for every decorator. 
> Namely content/css/styles.css
> This produces strange interactions with caching whenever there are fragments
> using two different layout decorations in the same page, or the user switches pages.
> The icons and styles are taken apparently randomly from both stylesheets, which
> plays havoc with the decoration.
> It looks like a solution for this would be to have the decoration name in the resource,
> like: 
>  now: content/images/edit.gif -> content/THEME/images/edit.gif
>  now: content/css/styles.css and content/THEME/css/styles.css -> content/THEME/css/layout-styles.css and content/THEME/css/portlet-styles.css
> Not sure if it was a bug or intended in the last batch of changes by Scott, so I just post here for clarification.
> Scott?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@portals.apache.org
For additional commands, e-mail: jetspeed-dev-help@portals.apache.org