You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/07 18:16:44 UTC
[GitHub] [spark] tgravescs opened a new pull request #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
tgravescs opened a new pull request #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
URL: https://github.com/apache/spark/pull/28146
…ial num executors
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
I found a bug in the stage level scheduling dynamic allocation code when you have a non default profile and it has an initial number of executors the same as what the number of executors needed for the first job, then we don't properly request the executors. This causes a hang.
The issue is that when a new stage is added and the initial number of executors is set, we set the target to be the initial number. Unfortunately that makes the code in the update and sync function think it has already requested that number. So to fix this, when there is an initial number we just go ahead and request executors at that point. This is basically what happens on startup to handle the case with the default profile.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
bug
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
unit test and manually test on yarn cluster. Went though multiple scenarios initial numbers, minimum number and number executor required by the first stage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28146: [SPARK-31378]
[CORE] stage level scheduling dynamic allocation bug with initial num
executors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610620421
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28146:
[SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with
initial num executors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610620429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120929/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28146: [SPARK-31378]
[CORE] stage level scheduling dynamic allocation bug with initial num
executors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610640120
Oh, got it. Thank you for informing that. That might be the root cause of conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28146: [SPARK-31378]
[CORE] stage level scheduling dynamic allocation bug with initial num
executors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610621245
Hi, @tgravescs . There is a merge conflict on `branch-3.0`. Could you make a backporting PR please?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28146: [SPARK-31378]
[CORE] stage level scheduling dynamic allocation bug with initial num
executors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610620429
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120929/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on issue #28146: [SPARK-31378] [CORE]
stage level scheduling dynamic allocation bug with initial num executors
Posted by GitBox <gi...@apache.org>.
tgravescs commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610622081
thanks @dongjoon-hyun yes, I'll put up another PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28146: [SPARK-31378]
[CORE] stage level scheduling dynamic allocation bug with initial num
executors
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610543943
**[Test build #120929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120929/testReport)** for PR 28146 at commit [`02124df`](https://github.com/apache/spark/commit/02124df83520134f48378f459202ad8f5893df26).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
URL: https://github.com/apache/spark/pull/28146#issuecomment-610544634
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
URL: https://github.com/apache/spark/pull/28146#issuecomment-610544634
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28146: [SPARK-31378] [CORE]
stage level scheduling dynamic allocation bug with initial num executors
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610619446
**[Test build #120929 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120929/testReport)** for PR 28146 at commit [`02124df`](https://github.com/apache/spark/commit/02124df83520134f48378f459202ad8f5893df26).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
URL: https://github.com/apache/spark/pull/28146#issuecomment-610544649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25621/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on issue #28146: [SPARK-31378] [CORE]
stage level scheduling dynamic allocation bug with initial num executors
Posted by GitBox <gi...@apache.org>.
tgravescs commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610632775
Note I updated the jira.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #28146: [SPARK-31378]
[CORE] stage level scheduling dynamic allocation bug with initial num
executors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
URL: https://github.com/apache/spark/pull/28146#issuecomment-610544649
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25621/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #28146: [SPARK-31378]
[CORE] stage level scheduling dynamic allocation bug with initial num
executors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610620500
Thank you, @tgravescs .
Merged to master/3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #28146:
[SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with
initial num executors
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610620500
Thank you, @tgravescs .
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with init…
URL: https://github.com/apache/spark/pull/28146#issuecomment-610543943
**[Test build #120929 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120929/testReport)** for PR 28146 at commit [`02124df`](https://github.com/apache/spark/commit/02124df83520134f48378f459202ad8f5893df26).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28146:
[SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with
initial num executors
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610620421
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on issue #28146: [SPARK-31378] [CORE]
stage level scheduling dynamic allocation bug with initial num executors
Posted by GitBox <gi...@apache.org>.
tgravescs commented on issue #28146: [SPARK-31378] [CORE] stage level scheduling dynamic allocation bug with initial num executors
URL: https://github.com/apache/spark/pull/28146#issuecomment-610632456
Sorry @dongjoon-hyun looks like I messed up. I thought this part of the feature had made it into 3.0 so targetted the jira there, but looks like it only went into 3.1.0, so no back port needed here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org