You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Guillaume Nodet <gn...@gmail.com> on 2009/08/13 11:00:45 UTC
[FileInstall] Several enhancements
I've raised a few jira issues on fileinstall that can be found at
https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=12310100&sorter/order=DESC&sorter/field=priority&resolution=-1&component=12312204
I plan to commit the attached patches for FELIX-1475, FELIX-1481, FELIX-1476
asap, so please review those and provide feedback is needed.
I'll attach another patch that will cover FELIX-922 and FELIX-1483, but I'd
like to gather feedback around the patch I already attached to FELIX-922 in
case someone objects to the design.
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [FileInstall] Several enhancements
Posted by Guillaume Nodet <gn...@gmail.com>.
I've uploaded new patches for 1475, 1476 and 1481 that are based on trunk
and do not need 922.
So they can be applied right now, and 922 will incorporate those changes
too.
On Thu, Aug 13, 2009 at 11:35, Sahoo <Sa...@sun.com> wrote:
> The patches for 1475, 1476 and 1481 look fine to me. How can you apply some
> of them, as they are based on patch for 922? I guess you shall rework them
> based on current svn. I am looking at 922, but it needs more time.
>
> Thanks,
> Sahoo
>
>
> Guillaume Nodet wrote:
>
>> I've raised a few jira issues on fileinstall that can be found at
>>
>>
>> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=12310100&sorter/order=DESC&sorter/field=priority&resolution=-1&component=12312204
>>
>> I plan to commit the attached patches for FELIX-1475, FELIX-1481,
>> FELIX-1476
>> asap, so please review those and provide feedback is needed.
>> I'll attach another patch that will cover FELIX-922 and FELIX-1483, but
>> I'd
>> like to gather feedback around the patch I already attached to FELIX-922
>> in
>> case someone objects to the design.
>>
>>
>>
>>
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [FileInstall] Several enhancements
Posted by Sahoo <Sa...@Sun.COM>.
The patches for 1475, 1476 and 1481 look fine to me. How can you apply
some of them, as they are based on patch for 922? I guess you shall
rework them based on current svn. I am looking at 922, but it needs more
time.
Thanks,
Sahoo
Guillaume Nodet wrote:
> I've raised a few jira issues on fileinstall that can be found at
>
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=12310100&sorter/order=DESC&sorter/field=priority&resolution=-1&component=12312204
>
> I plan to commit the attached patches for FELIX-1475, FELIX-1481, FELIX-1476
> asap, so please review those and provide feedback is needed.
> I'll attach another patch that will cover FELIX-922 and FELIX-1483, but I'd
> like to gather feedback around the patch I already attached to FELIX-922 in
> case someone objects to the design.
>
>
>
Re: [FileInstall] Several enhancements
Posted by Guillaume Nodet <gn...@gmail.com>.
I've committed those 3 patches, but I'm happy to continue the discussion.
For 1481, I'd be perfectly happy to add an escaping mechanism and keep
throwing an exception.
So if you want to use '$', '{' or '}' inside one value, you'd have to use
'\\$', '\\{' or '\\}' to escape those.
On Fri, Aug 14, 2009 at 10:53, Filippo Diotalevi <
filippo.diotalevi@gmail.com> wrote:
> On Thu, Aug 13, 2009 at 11:00 AM, Guillaume Nodet<gn...@gmail.com> wrote:
> > I've raised a few jira issues on fileinstall that can be found at
> >
> >
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=12310100&sorter/order=DESC&sorter/field=priority&resolution=-1&component=12312204
> >
> > I plan to commit the attached patches for FELIX-1475, FELIX-1481,
> FELIX-1476
> > asap, so please review those and provide feedback is needed.
>
> Hi,
> I've reviews 1475, 1476 and they look ok.
>
> 1481 (throw exception when stop delimiter isn't found): that was
> actually a good feature for me, because I could easily spot wrong
> configurations. However, if you need to have { } characters in your
> properties, I don't think there're other choices other than discarding
> the esception.
>
>
> --
> Filippo Diotalevi
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
Re: [FileInstall] Several enhancements
Posted by Filippo Diotalevi <fi...@gmail.com>.
On Thu, Aug 13, 2009 at 11:00 AM, Guillaume Nodet<gn...@gmail.com> wrote:
> I've raised a few jira issues on fileinstall that can be found at
>
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=12310100&sorter/order=DESC&sorter/field=priority&resolution=-1&component=12312204
>
> I plan to commit the attached patches for FELIX-1475, FELIX-1481, FELIX-1476
> asap, so please review those and provide feedback is needed.
Hi,
I've reviews 1475, 1476 and they look ok.
1481 (throw exception when stop delimiter isn't found): that was
actually a good feature for me, because I could easily spot wrong
configurations. However, if you need to have { } characters in your
properties, I don't think there're other choices other than discarding
the esception.
--
Filippo Diotalevi
Re: [FileInstall] Several enhancements
Posted by Guillaume Nodet <gn...@gmail.com>.
On Thu, Aug 13, 2009 at 21:11, Moloney, Tim M <Ti...@mantech.com>wrote:
>
> So would the convention be that:
>
> - .cfg files in the etc directory are monitored and any changes
> will be passed to the ConfigurationAdmin service
Right
>
>
> - other files in the etc directory are read once and not monitored
> for changes
>
Wrong. All known artifacts put in the etc folder will be handled as usual.
It's just that files in *.properties are not recognized and processed.
>
>
> Tim Moloney The reasonable man adapts himself to
> MRSL the world; the unreasonable one persists
> 2015 Cattlemen Road in trying to adapt the world to himself.
> Sarasota, FL 34232 Therefore all progress depends on the
> (941) 377-6775 x208 unreasonable man. George Bernard Shaw
>
>
>
> > -----Original Message-----
> > From: Guillaume Nodet [mailto:gnodet@gmail.com]
> > Sent: Thursday, August 13, 2009 11:52
> > To: dev@felix.apache.org
> > Subject: Re: [FileInstall] Several enhancements
> >
> > Well, FELIX-1475 is against fileinstall, but Karaf does not
> > use it yet.
> > So it will only work when the switch has been done (see FELIX-1463).
> > In addition, the default filter is empty, so Karaf will need
> > to properly set
> > the value to ".*\\.cfg" to only watch ".cfg" files in the etc folder.
> > I'm working on exploded artifacts right now and I'm mostly
> > done, so I should
> > have a patch ready tomorrow.
> >
> > On Thu, Aug 13, 2009 at 17:15, Moloney, Tim M
> > <Ti...@mantech.com>wrote:
> >
> > >
> > > I applied FELIX-1475 (and FELIX-1476 and FELIX-1481) to the current
> > > trunk see if it resolves FELIX-1480. Simply applying the
> > patch doesn't
> > > resolve the issue. I guess there is some configuration involved. I
> > > looked at the patch and I see that there is felix.fileinstall.filter
> > > (that I assume goes in config.properties), but this is for
> > FileInstall,
> > > not FileMonitor.
> > >
> > > I know that you are working to merge FileInstall and Deployer
> > > (FileMonitor), but I think that I'm missing something.
> > >
> > >
> > > Tim Moloney The reasonable man adapts himself to
> > > MRSL the world; the unreasonable one persists
> > > 2015 Cattlemen Road in trying to adapt the world to himself.
> > > Sarasota, FL 34232 Therefore all progress depends on the
> > > (941) 377-6775 x208 unreasonable man. George Bernard Shaw
> > >
> > >
> > >
> > > > -----Original Message-----
> > > > From: Guillaume Nodet [mailto:gnodet@gmail.com]
> > > > Sent: Thursday, August 13, 2009 05:01
> > > > To: dev
> > > > Subject: [FileInstall] Several enhancements
> > > >
> > > > I've raised a few jira issues on fileinstall that can be found at
> > > >
> > > > https://issues.apache.org/jira/secure/IssueNavigator.jspa?rese
> > >
> > t=true&mode=hide&pid=12310100<https://issues.apache.org/jira/s
> > ecure/IssueNavigator.jspa?rese%0At=true&mode=hide&pid=12310100>
> > > >
> > > &sorter/order=DESC&sorter/field=priority&resolution=-1&compone
> > > nt=12312204
> > > >
> > > > I plan to commit the attached patches for FELIX-1475,
> > > > FELIX-1481, FELIX-1476
> > > > asap, so please review those and provide feedback is needed.
> > > > I'll attach another patch that will cover FELIX-922 and
> > > > FELIX-1483, but I'd
> > > > like to gather feedback around the patch I already attached
> > > > to FELIX-922 in
> > > > case someone objects to the design.
> > > >
> > > >
> > > > --
> > > > Cheers,
> > > > Guillaume Nodet
> > > > ------------------------
> > > > Blog: http://gnodet.blogspot.com/
> > > > ------------------------
> > > > Open Source SOA
> > > > http://fusesource.com
> > > >
> > >
> >
> >
> >
> > --
> > Cheers,
> > Guillaume Nodet
> > ------------------------
> > Blog: http://gnodet.blogspot.com/
> > ------------------------
> > Open Source SOA
> > http://fusesource.com
> >
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
RE: [FileInstall] Several enhancements
Posted by "Moloney, Tim M" <Ti...@ManTech.com>.
So would the convention be that:
- .cfg files in the etc directory are monitored and any changes
will be passed to the ConfigurationAdmin service
- other files in the etc directory are read once and not monitored
for changes
Tim Moloney The reasonable man adapts himself to
MRSL the world; the unreasonable one persists
2015 Cattlemen Road in trying to adapt the world to himself.
Sarasota, FL 34232 Therefore all progress depends on the
(941) 377-6775 x208 unreasonable man. George Bernard Shaw
> -----Original Message-----
> From: Guillaume Nodet [mailto:gnodet@gmail.com]
> Sent: Thursday, August 13, 2009 11:52
> To: dev@felix.apache.org
> Subject: Re: [FileInstall] Several enhancements
>
> Well, FELIX-1475 is against fileinstall, but Karaf does not
> use it yet.
> So it will only work when the switch has been done (see FELIX-1463).
> In addition, the default filter is empty, so Karaf will need
> to properly set
> the value to ".*\\.cfg" to only watch ".cfg" files in the etc folder.
> I'm working on exploded artifacts right now and I'm mostly
> done, so I should
> have a patch ready tomorrow.
>
> On Thu, Aug 13, 2009 at 17:15, Moloney, Tim M
> <Ti...@mantech.com>wrote:
>
> >
> > I applied FELIX-1475 (and FELIX-1476 and FELIX-1481) to the current
> > trunk see if it resolves FELIX-1480. Simply applying the
> patch doesn't
> > resolve the issue. I guess there is some configuration involved. I
> > looked at the patch and I see that there is felix.fileinstall.filter
> > (that I assume goes in config.properties), but this is for
> FileInstall,
> > not FileMonitor.
> >
> > I know that you are working to merge FileInstall and Deployer
> > (FileMonitor), but I think that I'm missing something.
> >
> >
> > Tim Moloney The reasonable man adapts himself to
> > MRSL the world; the unreasonable one persists
> > 2015 Cattlemen Road in trying to adapt the world to himself.
> > Sarasota, FL 34232 Therefore all progress depends on the
> > (941) 377-6775 x208 unreasonable man. George Bernard Shaw
> >
> >
> >
> > > -----Original Message-----
> > > From: Guillaume Nodet [mailto:gnodet@gmail.com]
> > > Sent: Thursday, August 13, 2009 05:01
> > > To: dev
> > > Subject: [FileInstall] Several enhancements
> > >
> > > I've raised a few jira issues on fileinstall that can be found at
> > >
> > > https://issues.apache.org/jira/secure/IssueNavigator.jspa?rese
> >
> t=true&mode=hide&pid=12310100<https://issues.apache.org/jira/s
> ecure/IssueNavigator.jspa?rese%0At=true&mode=hide&pid=12310100>
> > >
> > &sorter/order=DESC&sorter/field=priority&resolution=-1&compone
> > nt=12312204
> > >
> > > I plan to commit the attached patches for FELIX-1475,
> > > FELIX-1481, FELIX-1476
> > > asap, so please review those and provide feedback is needed.
> > > I'll attach another patch that will cover FELIX-922 and
> > > FELIX-1483, but I'd
> > > like to gather feedback around the patch I already attached
> > > to FELIX-922 in
> > > case someone objects to the design.
> > >
> > >
> > > --
> > > Cheers,
> > > Guillaume Nodet
> > > ------------------------
> > > Blog: http://gnodet.blogspot.com/
> > > ------------------------
> > > Open Source SOA
> > > http://fusesource.com
> > >
> >
>
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>
Re: [FileInstall] Several enhancements
Posted by Guillaume Nodet <gn...@gmail.com>.
Well, FELIX-1475 is against fileinstall, but Karaf does not use it yet.
So it will only work when the switch has been done (see FELIX-1463).
In addition, the default filter is empty, so Karaf will need to properly set
the value to ".*\\.cfg" to only watch ".cfg" files in the etc folder.
I'm working on exploded artifacts right now and I'm mostly done, so I should
have a patch ready tomorrow.
On Thu, Aug 13, 2009 at 17:15, Moloney, Tim M <Ti...@mantech.com>wrote:
>
> I applied FELIX-1475 (and FELIX-1476 and FELIX-1481) to the current
> trunk see if it resolves FELIX-1480. Simply applying the patch doesn't
> resolve the issue. I guess there is some configuration involved. I
> looked at the patch and I see that there is felix.fileinstall.filter
> (that I assume goes in config.properties), but this is for FileInstall,
> not FileMonitor.
>
> I know that you are working to merge FileInstall and Deployer
> (FileMonitor), but I think that I'm missing something.
>
>
> Tim Moloney The reasonable man adapts himself to
> MRSL the world; the unreasonable one persists
> 2015 Cattlemen Road in trying to adapt the world to himself.
> Sarasota, FL 34232 Therefore all progress depends on the
> (941) 377-6775 x208 unreasonable man. George Bernard Shaw
>
>
>
> > -----Original Message-----
> > From: Guillaume Nodet [mailto:gnodet@gmail.com]
> > Sent: Thursday, August 13, 2009 05:01
> > To: dev
> > Subject: [FileInstall] Several enhancements
> >
> > I've raised a few jira issues on fileinstall that can be found at
> >
> > https://issues.apache.org/jira/secure/IssueNavigator.jspa?rese
> t=true&mode=hide&pid=12310100<https://issues.apache.org/jira/secure/IssueNavigator.jspa?rese%0At=true&mode=hide&pid=12310100>
> >
> &sorter/order=DESC&sorter/field=priority&resolution=-1&compone
> nt=12312204
> >
> > I plan to commit the attached patches for FELIX-1475,
> > FELIX-1481, FELIX-1476
> > asap, so please review those and provide feedback is needed.
> > I'll attach another patch that will cover FELIX-922 and
> > FELIX-1483, but I'd
> > like to gather feedback around the patch I already attached
> > to FELIX-922 in
> > case someone objects to the design.
> >
> >
> > --
> > Cheers,
> > Guillaume Nodet
> > ------------------------
> > Blog: http://gnodet.blogspot.com/
> > ------------------------
> > Open Source SOA
> > http://fusesource.com
> >
>
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
Open Source SOA
http://fusesource.com
RE: [FileInstall] Several enhancements
Posted by "Moloney, Tim M" <Ti...@ManTech.com>.
I applied FELIX-1475 (and FELIX-1476 and FELIX-1481) to the current
trunk see if it resolves FELIX-1480. Simply applying the patch doesn't
resolve the issue. I guess there is some configuration involved. I
looked at the patch and I see that there is felix.fileinstall.filter
(that I assume goes in config.properties), but this is for FileInstall,
not FileMonitor.
I know that you are working to merge FileInstall and Deployer
(FileMonitor), but I think that I'm missing something.
Tim Moloney The reasonable man adapts himself to
MRSL the world; the unreasonable one persists
2015 Cattlemen Road in trying to adapt the world to himself.
Sarasota, FL 34232 Therefore all progress depends on the
(941) 377-6775 x208 unreasonable man. George Bernard Shaw
> -----Original Message-----
> From: Guillaume Nodet [mailto:gnodet@gmail.com]
> Sent: Thursday, August 13, 2009 05:01
> To: dev
> Subject: [FileInstall] Several enhancements
>
> I've raised a few jira issues on fileinstall that can be found at
>
> https://issues.apache.org/jira/secure/IssueNavigator.jspa?rese
t=true&mode=hide&pid=12310100>
&sorter/order=DESC&sorter/field=priority&resolution=-1&compone
nt=12312204
>
> I plan to commit the attached patches for FELIX-1475,
> FELIX-1481, FELIX-1476
> asap, so please review those and provide feedback is needed.
> I'll attach another patch that will cover FELIX-922 and
> FELIX-1483, but I'd
> like to gather feedback around the patch I already attached
> to FELIX-922 in
> case someone objects to the design.
>
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
> ------------------------
> Open Source SOA
> http://fusesource.com
>