[jira] [Created] (SPARK-8628) Race condition in AbstractSparkSQLParser.parse

["Santiago M. Mola (JIRA)" <ji...@apache.org>]

Santiago M. Mola created SPARK-8628:
---------------------------------------

             Summary: Race condition in AbstractSparkSQLParser.parse
                 Key: SPARK-8628
                 URL: https://issues.apache.org/jira/browse/SPARK-8628
             Project: Spark
          Issue Type: Bug
          Components: SQL
    Affects Versions: 1.4.0, 1.3.1, 1.3.0
            Reporter: Santiago M. Mola
            Priority: Critical


SPARK-5009 introduced the following code:

def parse(input: String): LogicalPlan = {
    // Initialize the Keywords.
    lexical.initialize(reservedWords)
    phrase(start)(new lexical.Scanner(input)) match {
      case Success(plan, _) => plan
      case failureOrError => sys.error(failureOrError.toString)
    }
  }

The corresponding initialize method in SqlLexical is not thread-safe:

  /* This is a work around to support the lazy setting */
  def initialize(keywords: Seq[String]): Unit = {
    reserved.clear()
    reserved ++= keywords
  }

I'm hitting this when parsing multiple SQL queries concurrently. When one query parsing starts, it empties the reserved keyword list, then a race-condition occurs and other queries fail to parse because they recognize keywords as identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org