[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #18205: Fix nightly CD for GPU builds

[GitBox <gi...@apache.org>]

ChaiBapchya commented on a change in pull request #18205:
URL: https://github.com/apache/incubator-mxnet/pull/18205#discussion_r418167961



##########
File path: tools/pip/setup.py
##########
@@ -150,9 +150,8 @@ def skip_markdown_comments(md):
 package_data = {'mxnet': [os.path.join('mxnet', os.path.basename(LIB_PATH[0]))],
                 'dmlc_tracker': []}
 if variant.endswith('MKL'):
-    if platform.system() == 'Darwin':
-        shutil.copytree(os.path.join(CURRENT_DIR, 'mxnet-build/3rdparty/mkldnn/build/install/include'),
-                        os.path.join(CURRENT_DIR, 'mxnet/include/mkldnn'))
+    shutil.copytree(os.path.join(CURRENT_DIR, 'mxnet-build/3rdparty/mkldnn/build/install/include'),

Review comment:
       Curious how
   1. previously when nightly CD was working, why was mkldnn include done only for Darwin
   2. now, to fix nightly CD, this needs to be done for all OS




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org