[GitHub] [geode] jhutchison commented on pull request #5678: GEODE-8663: update Redis Info command To include additional statistics

[GitBox <gi...@apache.org>]

jhutchison commented on pull request #5678:
URL: https://github.com/apache/geode/pull/5678#issuecomment-718792965


   > It seems like there are some things to consider here that we could potentially discuss as a team or investigate more. Mostly around `keyspaceHits` and `keyspaceMisses`. Do we want to count those in the same way Redis does? One potential use case/argument for counting them the way Redis does is that a user might want to know how many times they tried to read something that wasn't in the database (it wouldn't really matter if they did a `SADD`, `SET`, or some other create operation and the key was null, for example, because it just gets added if it's not there). But I think you could make an argument either way.
   > 
   > Another thing to note is that our `total_commands_processed` is not currently the same as Redis, since Redis does not count unknown commands as processed commands, but we do.
   
   Yeah, let's talk this over as a team.  I think there were some decisions made early on in this workflow that maybe we need to think through together.  reverted to draft fro now.   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org