You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/01/25 01:33:36 UTC

[GitHub] ambition119 commented on a change in pull request #3418: Some minor fixes in Kafka-IO and Client-Cli

ambition119 commented on a change in pull request #3418: Some minor fixes in Kafka-IO and Client-Cli
URL: https://github.com/apache/pulsar/pull/3418#discussion_r250840146
 
 

 ##########
 File path: pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaSinkConfig.java
 ##########
 @@ -60,7 +60,7 @@
             "The batch size that Kafka producer will attempt to batch records together before sending them to brokers.")
     private long batchSize = 16384L;
     @FieldDoc(
-        defaultValue = "16384",
+        defaultValue = "1048576",
 
 Review comment:
   I just [PR](https://github.com/apache/pulsar/blob/d0f8aa6c7d06ad3ad22b373c390fd7b1db61d434/pulsar-io/nifi/src/main/java/org/apache/pulsar/io/nifi/NiFiConfig.java#L71) . if value int value, I also fix this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services