You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/12 07:31:36 UTC
[GitHub] [hudi] pintusoliya opened a new pull request, #6654: [DO NOT MERGE]: fix site tags various style issues
pintusoliya opened a new pull request, #6654:
URL: https://github.com/apache/hudi/pull/6654
### Change Logs
- fixed various tags style issue
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on pull request #6654: [DO NOT MERGE]: fix site tags various style issues
Posted by GitBox <gi...@apache.org>.
bhasudha commented on PR #6654:
URL: https://github.com/apache/hudi/pull/6654#issuecomment-1245882796
@pintusoliya I tried locally testing the patch. Couple of issues I noted
- When trying to open any blog page the page crashes with the message `editUrl is not a function`
- When listing all articles with a single tag, previously it was crowded and overlapped. Now all articles are displayed 1 after another like below which is better than before. But the image being too big and needing to scroll a lot with this view, can we make it display in grid style with two or three blogs per row (similar to blog landing page)? That way it is easy to scroll.
- The other thing I noticed is we need to disable reading time in the Blogs landing page. Since there are both external docs and native docs. External docs are redirected pages and reading time for them is displayed as 1 minute which doesn't make sense. We only want the reading time displayed when we open a blog. In the blogs landing page we don't need them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha commented on pull request #6654: [DO NOT MERGE]: fix site tags various style issues
Posted by GitBox <gi...@apache.org>.
bhasudha commented on PR #6654:
URL: https://github.com/apache/hudi/pull/6654#issuecomment-1245884295
Once these issues are fixed we are closer to landing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] bhasudha merged pull request #6654: [DOCS] fix site tags various style issues
Posted by GitBox <gi...@apache.org>.
bhasudha merged PR #6654:
URL: https://github.com/apache/hudi/pull/6654
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org