You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2023/02/28 14:06:02 UTC

[GitHub] [arrow] felipecrv opened a new issue, #34382: [C++] Run-end encoding and decoding: Add support for more types

felipecrv opened a new issue, #34382:
URL: https://github.com/apache/arrow/issues/34382

   ### Describe the enhancement requested
   
   #34195 introduces two functions `run_end_encode` and `run_end_decode`.
   
   The types supported are:
   
    - All `NumericTypes()`
    - `bool()`
    - `null()`
   
   More types should be supported and this issue is where we discuss which ones first.
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] dinimar commented on issue #34382: [C++] Run-end encoding and decoding: Add support for more types

Posted by "dinimar (via GitHub)" <gi...@apache.org>.
dinimar commented on issue #34382:
URL: https://github.com/apache/arrow/issues/34382#issuecomment-1473942726

   @felipecrv 
   As I found out in code there're `add_kernel()` function calls related to types you mentioned
   https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/cpp/src/arrow/compute/kernels/vector_run_end_encode.cc#L607-L612
   https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/cpp/src/arrow/compute/kernels/vector_run_end_encode.cc#L631-L636
   
   But simple adding `add_kernel()` function calls doesn't work. Tests start failing after that. Could you please explain how to add types for `run_end_encode` and `run_end_decode` properly?
   
   About types. As I see, in theory, it's possible to add all types using `add_kernel` (at least, it's easy for functions with empty arguments) listed in:
   https://github.com/apache/arrow/blob/f9324b79bf4fc1ec7e97b32e3cce16e75ef0f5e3/cpp/src/arrow/type_fwd.h#L456-L590
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] westonpace closed issue #34382: [C++] Run-end encoding and decoding: Add support for more types

Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace closed issue #34382: [C++] Run-end encoding and decoding: Add support for more types
URL: https://github.com/apache/arrow/issues/34382


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on issue #34382: [C++] Run-end encoding and decoding: Add support for more types

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #34382:
URL: https://github.com/apache/arrow/issues/34382#issuecomment-1474033910

   To add more types we need more specializations of `ReadValueImpl` and `WriteValueImpl` similaryly to how `visit_data_inline.h` does. The current specialization only works on types that have a `::c_type`. There needs to be one for `Binary, String` and another for fixed-size byte-string types like `FixedSizeBinary, Decimal256`.
   
   If we can make equality of values a template parameter, `RunEndEncodingLoop` could also be re-used for these specializations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] felipecrv commented on issue #34382: [C++] Run-end encoding and decoding: Add support for more types

Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #34382:
URL: https://github.com/apache/arrow/issues/34382#issuecomment-1487006369

   take


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org