You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/09/14 03:25:21 UTC

[GitHub] [bookkeeper] michaeljmarshall commented on a diff in pull request #3363: add writeThreadQueuedLatency

michaeljmarshall commented on code in PR #3363:
URL: https://github.com/apache/bookkeeper/pull/3363#discussion_r970270387


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PacketProcessorBase.java:
##########
@@ -152,6 +152,8 @@ protected void sendResponseAndWait(int rc, Object response, OpStatsLogger statsL
 
     @Override
     public void safeRun() {
+        requestProcessor.getRequestStats().getWriteThreadQueuedLatency()
+                .registerSuccessfulEvent(MathUtils.elapsedNanos(enqueueNanos), TimeUnit.NANOSECONDS);

Review Comment:
   This line will run for both read and write requests. I think that is fine because they share the same queue, but just want to mention it because the name indicates it is only running for writes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org