You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/06 11:10:15 UTC
[GitHub] [shardingsphere-elasticjob] BoulCheng opened a new pull request #1337: fix thread pools execute jobs uniformly
BoulCheng opened a new pull request #1337:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1337
Thread pools execute jobs uniformly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] BoulCheng commented on pull request #1337: fix thread pools execute jobs uniformly
Posted by GitBox <gi...@apache.org>.
BoulCheng commented on pull request #1337:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1337#issuecomment-670290587
> The change is not correct because if only one item assigned, it is unnecessary to create new thread to process it.
After JobBootstrap#shutdown() is called, The job is still executed if only one item assigned, there may still need to add a judgment on whether the thread pool is shutdown or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] BoulCheng closed pull request #1337: fix thread pools execute jobs uniformly
Posted by GitBox <gi...@apache.org>.
BoulCheng closed pull request #1337:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1337
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on pull request #1337: fix thread pools execute jobs uniformly
Posted by GitBox <gi...@apache.org>.
terrymanu commented on pull request #1337:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1337#issuecomment-669973770
I notice your pull request is wrong sometimes.
Can you discuss in issue before submit the pull request?
It is better to discuss first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org