You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/04/28 10:24:04 UTC

Review Request 58836: HiveView2.0: Visual Explain graph zooms out on scrolling down

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58836/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20146
    https://issues.apache.org/jira/browse/AMBARI-20146


Repository: ambari


Description
-------

Introducing manual zoom in and zoom out.


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 29646cc 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 2edeab2 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4 


Diff: https://reviews.apache.org/r/58836/diff/1/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha


Re: Review Request 58836: HiveView2.0: Visual Explain graph zooms out on scrolling down

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58836/#review173310
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On April 28, 2017, 10:24 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58836/
> -----------------------------------------------------------
> 
> (Updated April 28, 2017, 10:24 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20146
>     https://issues.apache.org/jira/browse/AMBARI-20146
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Introducing manual zoom in and zoom out.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 29646cc 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 2edeab2 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4 
> 
> 
> Diff: https://reviews.apache.org/r/58836/diff/1/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 58836: HiveView2.0: Visual Explain graph zooms out on scrolling down

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58836/#review173422
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On April 29, 2017, 7:03 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58836/
> -----------------------------------------------------------
> 
> (Updated April 29, 2017, 7:03 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20146
>     https://issues.apache.org/jira/browse/AMBARI-20146
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Introducing manual zoom in and zoom out.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 29646cc 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 2edeab2 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 298366f 
>   contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4 
> 
> 
> Diff: https://reviews.apache.org/r/58836/diff/2/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>


Re: Review Request 58836: HiveView2.0: Visual Explain graph zooms out on scrolling down

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58836/
-----------------------------------------------------------

(Updated April 29, 2017, 7:03 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20146
    https://issues.apache.org/jira/browse/AMBARI-20146


Repository: ambari


Description
-------

Introducing manual zoom in and zoom out.


Diffs (updated)
-----

  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 29646cc 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 2edeab2 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js 298366f 
  contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 4d9eff4 


Diff: https://reviews.apache.org/r/58836/diff/2/

Changes: https://reviews.apache.org/r/58836/diff/1-2/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha