You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/13 09:07:15 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
HyukjinKwon opened a new pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901
### What changes were proposed in this pull request?
This PR is kind of a followup of #26808. It leverages the helper method for aliasing in all SQL expressions to use the alias as its output column name.
- `Expression`, `UnaryMathExpression` and `BinaryMathExpression` search the alias in the tags by default.
- When the naming is different in its implementation, it has to be overwritten for the expression specifically. E.g., `EqualTo`, `CallMethodViaReflection`, `Remainder`, `CurrentTimestamp`, `FormatString` and `XPathDouble`.
### Why are the changes needed?
To respect expression name.
### Does this PR introduce any user-facing change?
Yes, it will change the output column name.
### How was this patch tested?
Manually tested, and unittests were added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599176821
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598685700
**[Test build #119750 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119750/testReport)** for PR 27901 at commit [`882371d`](https://github.com/apache/spark/commit/882371d0dff5ab70b140e8bf243ba08ceeea5e80).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598685944
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119750/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598675360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24486/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599197596
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119813/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392428784
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -590,7 +590,9 @@ object FunctionRegistry {
if (varargCtor.isDefined) {
// If there is an apply method that accepts Seq[Expression], use that one.
try {
- varargCtor.get.newInstance(expressions).asInstanceOf[Expression]
+ val exp = varargCtor.get.newInstance(expressions).asInstanceOf[Expression]
+ if (setAlias) exp.setTagValue(FUNC_ALIAS, name)
Review comment:
It's nice. BTW, does this increase the memory usage for complex queries using many functions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598878194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24501/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392430435
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out
##########
@@ -4654,111 +4654,111 @@ struct<id:bigint>
-- !query
select ln(1.2345678e-28)
-- !query schema
-struct<LOG(1.2345678E-28):double>
+struct<log(1.2345678E-28):double>
Review comment:
Can we have `ln` instead of `log`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598685944
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119750/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598622218
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24479/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392640047
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -590,7 +590,9 @@ object FunctionRegistry {
if (varargCtor.isDefined) {
// If there is an apply method that accepts Seq[Expression], use that one.
try {
- varargCtor.get.newInstance(expressions).asInstanceOf[Expression]
+ val exp = varargCtor.get.newInstance(expressions).asInstanceOf[Expression]
+ if (setAlias) exp.setTagValue(FUNC_ALIAS, name)
Review comment:
Hm, I think it's okay. Even if so, logically the alias should have the correct name so I would like to treat it as unavoidable even if it brings some more memory usage.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599168680
**[Test build #119809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119809/testReport)** for PR 27901 at commit [`b3f40a1`](https://github.com/apache/spark/commit/b3f40a1c7efd5ac07b6c45a31ace6aaa90416472).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-606970052
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392837101
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
Actually I was thinking about this one. Seems few expressions override `nodeName` directly but I am not sure if that's correct. Node name seems to be usually the class name; not lower-cased names. Fixing `prettyName` looks good enough to address the issue in output column names.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598621711
**[Test build #119750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119750/testReport)** for PR 27901 at commit [`882371d`](https://github.com/apache/spark/commit/882371d0dff5ab70b140e8bf243ba08ceeea5e80).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598690571
**[Test build #119759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119759/testReport)** for PR 27901 at commit [`0809771`](https://github.com/apache/spark/commit/0809771b2fce17e8f5a6d31458892551b81eca8b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598691133
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24488/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598798251
**[Test build #119759 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119759/testReport)** for PR 27901 at commit [`0809771`](https://github.com/apache/spark/commit/0809771b2fce17e8f5a6d31458892551b81eca8b).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392693113
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
+ override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse("reflect")
Review comment:
Does this change from `reflect` to `java_method` for `CallMethodViaReflection`? Why not keep `reflect`? Isn't this a breaking change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392856016
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
anyway my point is: `nodeName` is used in multiple string methods `prettyName`, `simpleString`, etc. Seems better to make them consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599168753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24539/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598691133
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24488/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598798994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119759/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598878184
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392746619
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
+ override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse("reflect")
Review comment:
@viirya, it changes from `reflect` to `java_method` when `java_method` is used, which I believe is correct. It will still show `reflect` when `reflect` is used.
```scala
scala> spark.range(1).selectExpr("java_method('java.util.UUID', 'randomUUID')").show()
+---------------------------------------+
|java_method(java.util.UUID, randomUUID)|
+---------------------------------------+
| c1b2961e-ccc4-4ad...|
+---------------------------------------+
scala> spark.range(1).selectExpr("reflect('java.util.UUID', 'randomUUID')").show()
+-----------------------------------+
|reflect(java.util.UUID, randomUUID)|
+-----------------------------------+
| 587b9a03-63f1-424...|
+-----------------------------------+
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599177237
**[Test build #119813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119813/testReport)** for PR 27901 at commit [`b3f40a1`](https://github.com/apache/spark/commit/b3f40a1c7efd5ac07b6c45a31ace6aaa90416472).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598976110
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119772/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598743856
**[Test build #119757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119757/testReport)** for PR 27901 at commit [`536b747`](https://github.com/apache/spark/commit/536b7476150120c0b22c27cf75bfb19e65e65086).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598621711
**[Test build #119750 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119750/testReport)** for PR 27901 at commit [`882371d`](https://github.com/apache/spark/commit/882371d0dff5ab70b140e8bf243ba08ceeea5e80).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392432998
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -252,20 +252,20 @@ object FunctionRegistry {
expression[Log1p]("log1p"),
expression[Log2]("log2"),
expression[Log]("ln"),
Review comment:
`expression[Log]("ln", true),`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599197596
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119813/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598877731
**[Test build #119772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119772/testReport)** for PR 27901 at commit [`0809771`](https://github.com/apache/spark/commit/0809771b2fce17e8f5a6d31458892551b81eca8b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392693113
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
+ override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse("reflect")
Review comment:
Does this change from `reflect` to `java_method` for `CallMethodViaReflection`? Why not keep `reflect`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598744125
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119757/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598622206
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392829594
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
Shall we just override the node name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598691124
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392641318
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out
##########
@@ -4654,111 +4654,111 @@ struct<id:bigint>
-- !query
select ln(1.2345678e-28)
-- !query schema
-struct<LOG(1.2345678E-28):double>
+struct<log(1.2345678E-28):double>
Review comment:
I actually realised that there are some more instances such as `ToDegrees`, `ToRadians`, `UnaryMinus` and `UnaryPositive`.. let me exclude these to make the scope my PR addresses smaller
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599175884
**[Test build #119809 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119809/testReport)** for PR 27901 at commit [`b3f40a1`](https://github.com/apache/spark/commit/b3f40a1c7efd5ac07b6c45a31ace6aaa90416472).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598674916
**[Test build #119757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119757/testReport)** for PR 27901 at commit [`536b747`](https://github.com/apache/spark/commit/536b7476150120c0b22c27cf75bfb19e65e65086).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598976108
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599176703
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599168749
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599301603
I don't think we have made guarantee on the output column name. Also, I would think this is as a rather bug fix. We have already made such changes a lot in the history.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599168749
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599176824
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24543/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392869652
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
Yes, I agree with that point. But here why don't we just don't touch `nodeName` and revisit next time?
If we override `prettyName`, most of cases such as `simpleString` and `sql` and will be addressed.
My impression about `prettyName` via `sql` call is user-facing string (as it's used in `sql` as of https://github.com/apache/spark/commit/d9efe63ecdc60a9955f1924de0e8a00bcb6a559d). and `nodeName` seems more like related to internal and debugging. If we have to debug, we should take a look for class names rather then what alias was used by the user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392829020
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
+ override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse("reflect")
Review comment:
I don't think we guarantee the auto-generated alias name. It's very fragile and can get changed super easily without noticing. AFAIK it has been changed many times in the past.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598877731
**[Test build #119772 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119772/testReport)** for PR 27901 at commit [`0809771`](https://github.com/apache/spark/commit/0809771b2fce17e8f5a6d31458892551b81eca8b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599176824
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24543/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599175924
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599022528
Looks nice. For easy trackability in commit logs, could you add a list of the functions (that this PR adds alias flags for) in the PR description?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598690571
**[Test build #119759 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119759/testReport)** for PR 27901 at commit [`0809771`](https://github.com/apache/spark/commit/0809771b2fce17e8f5a6d31458892551b81eca8b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598975824
**[Test build #119772 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119772/testReport)** for PR 27901 at commit [`0809771`](https://github.com/apache/spark/commit/0809771b2fce17e8f5a6d31458892551b81eca8b).
* This patch **fails SparkR unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-606970052
~~Sure~~. I am sorry, I rushed to read. I think we haven't documented such output column names in the migration so far, e.g., https://github.com/apache/spark/pull/26808. Let me leave it out for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598878194
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24501/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598876830
Retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392630835
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/float8.sql.out
##########
@@ -490,191 +490,191 @@ struct<five:string,f1:double>
-- !query
SELECT sinh(double('1'))
-- !query schema
-struct<SINH(CAST(1 AS DOUBLE)):double>
+struct<sinh(CAST(1 AS DOUBLE)):double>
-- !query output
1.1752011936438014
-- !query
SELECT cosh(double('1'))
-- !query schema
-struct<COSH(CAST(1 AS DOUBLE)):double>
+struct<cosh(CAST(1 AS DOUBLE)):double>
-- !query output
1.543080634815244
-- !query
SELECT tanh(double('1'))
-- !query schema
-struct<TANH(CAST(1 AS DOUBLE)):double>
+struct<tanh(CAST(1 AS DOUBLE)):double>
-- !query output
0.7615941559557649
-- !query
SELECT asinh(double('1'))
-- !query schema
-struct<ASINH(CAST(1 AS DOUBLE)):double>
+struct<asinh(CAST(1 AS DOUBLE)):double>
-- !query output
0.8813735870195429
-- !query
SELECT acosh(double('2'))
-- !query schema
-struct<ACOSH(CAST(2 AS DOUBLE)):double>
+struct<acosh(CAST(2 AS DOUBLE)):double>
-- !query output
1.3169578969248166
-- !query
SELECT atanh(double('0.5'))
-- !query schema
-struct<ATANH(CAST(0.5 AS DOUBLE)):double>
+struct<atanh(CAST(0.5 AS DOUBLE)):double>
-- !query output
0.5493061443340548
-- !query
SELECT sinh(double('Infinity'))
-- !query schema
-struct<SINH(CAST(Infinity AS DOUBLE)):double>
+struct<sinh(CAST(Infinity AS DOUBLE)):double>
-- !query output
Infinity
-- !query
SELECT sinh(double('-Infinity'))
-- !query schema
-struct<SINH(CAST(-Infinity AS DOUBLE)):double>
+struct<sinh(CAST(-Infinity AS DOUBLE)):double>
-- !query output
-Infinity
-- !query
SELECT sinh(double('NaN'))
-- !query schema
-struct<SINH(CAST(NaN AS DOUBLE)):double>
+struct<sinh(CAST(NaN AS DOUBLE)):double>
-- !query output
NaN
-- !query
SELECT cosh(double('Infinity'))
-- !query schema
-struct<COSH(CAST(Infinity AS DOUBLE)):double>
+struct<cosh(CAST(Infinity AS DOUBLE)):double>
Review comment:
Can we keep this unchanged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598622218
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24479/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598976110
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119772/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-607005047
And I think we don't also guarantee on output columns names (https://github.com/apache/spark/pull/27901#issuecomment-599301603).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599177237
**[Test build #119813 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119813/testReport)** for PR 27901 at commit [`b3f40a1`](https://github.com/apache/spark/commit/b3f40a1c7efd5ac07b6c45a31ace6aaa90416472).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598798984
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392431979
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -20,7 +20,7 @@ package org.apache.spark.sql.catalyst.expressions
import scala.collection.immutable.TreeSet
import org.apache.spark.sql.catalyst.InternalRow
-import org.apache.spark.sql.catalyst.analysis.TypeCheckResult
+import org.apache.spark.sql.catalyst.analysis.{FunctionRegistry, TypeCheckResult}
Review comment:
Shall we revert this file change since this is not required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599175924
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598685935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392854623
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
damn I miss read it. Then it won't work for physical plans as we remove the `Exec` postfix. And I would say it's much more reliable to use `getClass.getSimpleName` in this case...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599197410
**[Test build #119813 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119813/testReport)** for PR 27901 at commit [`b3f40a1`](https://github.com/apache/spark/commit/b3f40a1c7efd5ac07b6c45a31ace6aaa90416472).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599197592
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598744125
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119757/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392641318
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/numeric.sql.out
##########
@@ -4654,111 +4654,111 @@ struct<id:bigint>
-- !query
select ln(1.2345678e-28)
-- !query schema
-struct<LOG(1.2345678E-28):double>
+struct<log(1.2345678E-28):double>
Review comment:
I actually realised that there are some more instances such as `ToDegrees`, `ToRadians`, `UnaryMinus` and `UnaryPositive`.. let me exclude this these to make the scope my PR address smaller
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598798984
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599168753
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24539/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598685935
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599176821
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392753020
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
+ override def prettyName: String = getTagValue(FunctionRegistry.FUNC_ALIAS).getOrElse("reflect")
Review comment:
Yea, if a code relies on the output column name of `selectExpr("java_method(...)")`, it could be broken as it is changed to `java_method(...)` now. This is correct, I think. If we don't guarantee on the output column name, it is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598622206
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392840726
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
But `asCode` says:
> Returns a 'scala code' representation of this `TreeNode` and its children.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392640299
##########
File path: sql/core/src/test/resources/sql-tests/results/postgreSQL/float8.sql.out
##########
@@ -490,191 +490,191 @@ struct<five:string,f1:double>
-- !query
SELECT sinh(double('1'))
-- !query schema
-struct<SINH(CAST(1 AS DOUBLE)):double>
+struct<sinh(CAST(1 AS DOUBLE)):double>
-- !query output
1.1752011936438014
-- !query
SELECT cosh(double('1'))
-- !query schema
-struct<COSH(CAST(1 AS DOUBLE)):double>
+struct<cosh(CAST(1 AS DOUBLE)):double>
-- !query output
1.543080634815244
-- !query
SELECT tanh(double('1'))
-- !query schema
-struct<TANH(CAST(1 AS DOUBLE)):double>
+struct<tanh(CAST(1 AS DOUBLE)):double>
-- !query output
0.7615941559557649
-- !query
SELECT asinh(double('1'))
-- !query schema
-struct<ASINH(CAST(1 AS DOUBLE)):double>
+struct<asinh(CAST(1 AS DOUBLE)):double>
-- !query output
0.8813735870195429
-- !query
SELECT acosh(double('2'))
-- !query schema
-struct<ACOSH(CAST(2 AS DOUBLE)):double>
+struct<acosh(CAST(2 AS DOUBLE)):double>
-- !query output
1.3169578969248166
-- !query
SELECT atanh(double('0.5'))
-- !query schema
-struct<ATANH(CAST(0.5 AS DOUBLE)):double>
+struct<atanh(CAST(0.5 AS DOUBLE)):double>
-- !query output
0.5493061443340548
-- !query
SELECT sinh(double('Infinity'))
-- !query schema
-struct<SINH(CAST(Infinity AS DOUBLE)):double>
+struct<sinh(CAST(Infinity AS DOUBLE)):double>
-- !query output
Infinity
-- !query
SELECT sinh(double('-Infinity'))
-- !query schema
-struct<SINH(CAST(-Infinity AS DOUBLE)):double>
+struct<sinh(CAST(-Infinity AS DOUBLE)):double>
-- !query output
-Infinity
-- !query
SELECT sinh(double('NaN'))
-- !query schema
-struct<SINH(CAST(NaN AS DOUBLE)):double>
+struct<sinh(CAST(NaN AS DOUBLE)):double>
-- !query output
NaN
-- !query
SELECT cosh(double('Infinity'))
-- !query schema
-struct<COSH(CAST(Infinity AS DOUBLE)):double>
+struct<cosh(CAST(Infinity AS DOUBLE)):double>
Review comment:
Yup, I think that will scope this PR smaller, and I don't have to fix R tests as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392432998
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -252,20 +252,20 @@ object FunctionRegistry {
expression[Log1p]("log1p"),
expression[Log2]("log2"),
expression[Log]("ln"),
Review comment:
`expression[Log]("ln", true),`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598744116
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392854623
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
damn I miss read it. Then it won't work for physical plans as we remove the `Exec` postfix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599828026
Thank you guys!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599175927
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119809/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599168680
**[Test build #119809 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119809/testReport)** for PR 27901 at commit [`b3f40a1`](https://github.com/apache/spark/commit/b3f40a1c7efd5ac07b6c45a31ace6aaa90416472).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598878184
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599169480
cc @cloud-fan too - I realised that you touched lots of codes related to this during commit history search.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599197592
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598976108
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-599175927
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119809/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-606875319
We need to update the migration guide. This impacts the output schema of SQL queries.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598979226
Oh, R failure is relevant one.
```
test_sparkSQL.R:1785: failure: column binary mathfunctions
collect(select(df, atan2(df$a, df$b)))[1, "ATAN2(a, b)"] not equal to atan2(1, 5).
target is NULL, current is numeric
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598675360
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24486/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598798994
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/119759/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598675348
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392838833
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
It's good enough, but I don't think `nodeName` is designed to represent the class name. For example, `TreeNode.asCode` expects `nodeName` to be the function name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in all SQL expressions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598674916
**[Test build #119757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/119757/testReport)** for PR 27901 at commit [`536b747`](https://github.com/apache/spark/commit/536b7476150120c0b22c27cf75bfb19e65e65086).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598691124
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL
expressions
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#discussion_r392881525
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CallMethodViaReflection.scala
##########
@@ -55,7 +55,7 @@ import org.apache.spark.util.Utils
case class CallMethodViaReflection(children: Seq[Expression])
extends Expression with CodegenFallback {
- override def prettyName: String = "reflect"
Review comment:
ok makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27901: [SPARK-31146][SQL]
Leverage the helper method for aliasing in built-in SQL expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in built-in SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598744116
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27901:
[SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL
expressions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27901: [SPARK-31146][SQL] Leverage the helper method for aliasing in all SQL expressions
URL: https://github.com/apache/spark/pull/27901#issuecomment-598675348
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org