You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/07/02 07:45:51 UTC
[GitHub] [cloudstack-cloudmonkey] Pearl1594 opened a new pull request #82: Prevent ACS commands starting with sync to get redirected to API discovery
Pearl1594 opened a new pull request #82:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/82
Fixes: https://github.com/apache/cloudstack-cloudmonkey/issues/81
```
/go/src/github.com/pearl1594/cloudstack-cloudmonkey$ go run cmk.go
Apache CloudStack 🐵 CloudMonkey 6.1.0
Report issues: https://github.com/apache/cloudstack-cloudmonkey/issues
(localcloud) 🐱 > sync storagepool id=0bbd54fe-b348-3e3d-9b91-b453a21bc43a (PS2)
{
"accountid": "6b71e9af-cf22-11eb-9edd-50eb7122da94",
"cmd": "org.apache.cloudstack.api.command.admin.storage.SyncStoragePoolCmd",
"completed": "2021-07-02T13:01:21+0530",
"created": "2021-07-02T13:01:21+0530",
"jobid": "0cd7299c-679a-4691-b990-1fce8f9ddf4f",
"jobprocstatus": 0,
"jobresult": {
"errorcode": 431,
"errortext": "SyncStoragePool API is currently supported only for storage type of datastore cluster"
},
"jobresultcode": 530,
"jobresulttype": "object",
"jobstatus": 2,
"userid": "6b71f7f1-cf22-11eb-9edd-50eb7122da94"
}
🙈 Error: async API failed for job 0cd7299c-679a-4691-b990-1fce8f9ddf4f
(localcloud) 🐱 > sync
Discovered 604 APIs
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] Pearl1594 commented on pull request #82: Prevent ACS commands starting with sync to get redirected to API discovery
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #82:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/82#issuecomment-872793141
@shwstppr @harikrishna-patnala Can you please help review/test this. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] shwstppr commented on a change in pull request #82: Prevent ACS commands starting with sync to get redirected to API discovery
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #82:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/82#discussion_r662828978
##########
File path: cli/exec.go
##########
@@ -58,7 +58,7 @@ func ExecCmd(args []string) error {
}
command := cmd.FindCommand(args[0])
- if command != nil {
+ if command != nil && ((args[0] == "sync" && len(args) == 1) || args[0] != "sync") {
Review comment:
```suggestion
if command != nil && !(args[0] == "sync" && len(args) > 1) {
```
Shorter check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-cloudmonkey] rhtyd merged pull request #82: Prevent ACS commands starting with sync to get redirected to API discovery
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #82:
URL: https://github.com/apache/cloudstack-cloudmonkey/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org