You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/05 01:49:48 UTC
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3501: fix: remove kubectl dependency in chaos test, use k8s API instead
Yiyiyimu commented on a change in pull request #3501:
URL: https://github.com/apache/apisix/pull/3501#discussion_r570666510
##########
File path: t/chaos/go.mod
##########
@@ -1,8 +1,38 @@
module github.com/apache/apisix/t/chaos
require (
+ github.com/chaos-mesh/chaos-mesh v1.1.1
github.com/gavv/httpexpect/v2 v2.1.0
github.com/onsi/gomega v1.9.0
+ k8s.io/api v0.17.0
+ k8s.io/apimachinery v0.17.0
+ k8s.io/client-go v0.17.0
+ k8s.io/kubectl v0.0.0
+ sigs.k8s.io/controller-runtime v0.4.0
+)
+
+replace (
+ k8s.io/api => k8s.io/api v0.17.0
+ k8s.io/apiextensions-apiserver => k8s.io/apiextensions-apiserver v0.17.0
+ k8s.io/apimachinery => k8s.io/apimachinery v0.17.1-beta.0
+ k8s.io/apiserver => k8s.io/apiserver v0.17.0
+ k8s.io/cli-runtime => k8s.io/cli-runtime v0.17.0
+ k8s.io/client-go => k8s.io/client-go v0.17.0
+ k8s.io/cloud-provider => k8s.io/cloud-provider v0.17.0
+ k8s.io/cluster-bootstrap => k8s.io/cluster-bootstrap v0.17.0
+ k8s.io/code-generator => k8s.io/code-generator v0.17.1-beta.0
+ k8s.io/component-base => k8s.io/component-base v0.17.0
+ k8s.io/cri-api => k8s.io/cri-api v0.17.1-beta.0
+ k8s.io/csi-translation-lib => k8s.io/csi-translation-lib v0.17.0
+ k8s.io/kube-aggregator => k8s.io/kube-aggregator v0.17.0
+ k8s.io/kube-controller-manager => k8s.io/kube-controller-manager v0.17.0
+ k8s.io/kube-proxy => k8s.io/kube-proxy v0.17.0
+ k8s.io/kube-scheduler => k8s.io/kube-scheduler v0.17.0
+ k8s.io/kubectl => k8s.io/kubectl v0.17.0
+ k8s.io/kubelet => k8s.io/kubelet v0.17.0
+ k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.17.0
+ k8s.io/metrics => k8s.io/metrics v0.17.0
+ k8s.io/sample-apiserver => k8s.io/sample-apiserver v0.17.0
Review comment:
Chaos-mesh directly use `k8s.io/kubernetes` which is not recommended by Kubernetes, due to many dependencies of `k8s.io/kubernetes` is not declared and all would be `v0.0.0`. Some discussion could be found in https://github.com/chaos-mesh/chaos-mesh/issues/1289
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org