[GitHub] [spark] amaliujia commented on a diff in pull request #38546: [SPARK-41036][CONNECT][PYTHON] `columns` API should use `schema` API to avoid data fetching

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38546:
URL: https://github.com/apache/spark/pull/38546#discussion_r1017484449


##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -139,11 +139,9 @@ def columns(self) -> List[str]:
         if self._plan is None:
             return []
         if "columns" not in self._cache and self._plan is not None:
-            pdd = self.limit(0).toPandas()

Review Comment:
   I would prefer to not depend on the underly API when doing caching...
   
   E.g. what if someday the cache on the schema is gone but this API is not aware of it, etc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org