You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Liviu Tudor (JIRA)" <ji...@apache.org> on 2012/07/31 02:09:33 UTC
[jira] [Created] (POOL-227) Unit test failures due to getMinIdle
changes
Liviu Tudor created POOL-227:
--------------------------------
Summary: Unit test failures due to getMinIdle changes
Key: POOL-227
URL: https://issues.apache.org/jira/browse/POOL-227
Project: Commons Pool
Issue Type: Bug
Affects Versions: 1.6
Reporter: Liviu Tudor
Priority: Minor
Fix For: 1.6.1
Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
* TestGenericKeyedObjectPool
* TestGenericKeyedObjectPoolFactory
* TestGenericObjectPoolFactory
As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Liviu Tudor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426071#comment-13426071 ]
Liviu Tudor commented on POOL-227:
----------------------------------
Hi guys I'm really sorry, it seems to be my Eclipse which auto-formats on save.
I'll review that and submit a new patch. As a side question though, is there a settings/xml somewhere for all the commons projects? The settings that I'm using currently work fine with functor but seems to obviously cause problems with pool :(
Also, since we're on the subject of unit tests -- I am waiting for some feedback on POOL-228 -- not sure again if tests need changing or the logic is err'd? Could either of you shed some light into it?
Cheers.
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Mark Thomas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426053#comment-13426053 ]
Mark Thomas commented on POOL-227:
----------------------------------
Patch is unreviewable. Far too many whitespace changes and associated noise. I am not going to wade through all of that.
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Mark Thomas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426373#comment-13426373 ]
Mark Thomas commented on POOL-227:
----------------------------------
The patch is consistent with the expected behaviour. +1 to applying it.
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.2.patch, POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Liviu Tudor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liviu Tudor updated POOL-227:
-----------------------------
Attachment: POOL-227.2.patch
reviewed patch without the whitespaces problems
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.2.patch, POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Liviu Tudor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Liviu Tudor updated POOL-227:
-----------------------------
Attachment: POOL-227.patch
changed unit tests.
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Liviu Tudor (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426098#comment-13426098 ]
Liviu Tudor commented on POOL-227:
----------------------------------
OK so it seems the whitespace problem is only in TestGenericKeyedObjectPool which has got pretty bad whitespacing -- compared to the other sources. But I can see this is not one of the "rules" in checkstyle so I guess I need to leave the formatting/spacing unchanged.
The other 2 files seem fine though.
Will re-submit momentarily.
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gary D. Gregory resolved POOL-227.
----------------------------------
Resolution: Fixed
commit -m "[POOL-227] Unit test failures due to getMinIdle changes." C:/svn/org/apache/commons/branches/pool-1.x/src/test/org/apache/commons/pool/impl/TestGenericObjectPoolFactory.java C:/svn/org/apache/commons/branches/pool-1.x/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java C:/svn/org/apache/commons/branches/pool-1.x/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java C:/svn/org/apache/commons/branches/pool-1.x/src/changes/changes.xml
Sending C:/svn/org/apache/commons/branches/pool-1.x/src/changes/changes.xml
Sending C:/svn/org/apache/commons/branches/pool-1.x/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPool.java
Sending C:/svn/org/apache/commons/branches/pool-1.x/src/test/org/apache/commons/pool/impl/TestGenericKeyedObjectPoolFactory.java
Sending C:/svn/org/apache/commons/branches/pool-1.x/src/test/org/apache/commons/pool/impl/TestGenericObjectPoolFactory.java
Transmitting file data ...
Committed revision 1367957.
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.2.patch, POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (POOL-227) Unit test failures due to getMinIdle
changes
Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425703#comment-13425703 ]
Gary D. Gregory commented on POOL-227:
--------------------------------------
Mark,
Can you confirm that these changes are OK?
Thank you,
Gary
> Unit test failures due to getMinIdle changes
> --------------------------------------------
>
> Key: POOL-227
> URL: https://issues.apache.org/jira/browse/POOL-227
> Project: Commons Pool
> Issue Type: Bug
> Affects Versions: 1.6
> Reporter: Liviu Tudor
> Priority: Minor
> Labels: junit
> Fix For: 1.6.1
>
> Attachments: POOL-227.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Following changes in POOL-212 to do with {{getMinIdle}} logic, the following unit tests started failing:
> * TestGenericKeyedObjectPool
> * TestGenericKeyedObjectPoolFactory
> * TestGenericObjectPoolFactory
> As per discussion with Mark around this, the tests now need changing to reflect the new logic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira