[GitHub] ccollins476ad opened a new pull request #75: Fix broken generated sysinit for: 1 package, 1 stage, 2 functions

[gi...@git.apache.org]

ccollins476ad opened a new pull request #75: Fix broken generated sysinit for: 1 package, 1 stage, 2 functions
URL: https://github.com/apache/incubator-mynewt-newt/pull/75
 
 
   Newt generated incorrect code when one package specified two init
   functions with the same stage number.  For example, if we add a function
   called init2() to the net/nimble/host init map:
   
       pkg.init:
           ble_hs_init: 200
           init2: 200
   
   The following code would get generated:
   
       /*** Stage 200 */
       /* 200.0: net/nimble/host */
       init2();
       /* 200.1: net/nimble/host */
       init2();
   
   i.e., two calls to init2(), but none to ble_hs_init().
   
   Furthermore, the ordering of the prototype list was inconsistent,
   leading to unnecessary recompiles of the sysinit c file.
   
   Now, the prototype list and the init function calls get sorted as
   follows:
   
   1. stage number (ascending)
   2. function name (ascending)
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services