You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2003/09/19 15:05:10 UTC
[jira] Updated: (MAVEN-831) Can't specify location of web.xml
The following issue has been updated:
Updater: Brian Murray (mailto:brian.c.murray@vanderbilt.edu)
Date: Fri, 19 Sep 2003 8:04 AM
Comment:
Attached minimalist patch to copy web.xml specified by ${maven.war.webxml}
Changes:
Attachment changed to warpluginjellydiff.txt
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-831&page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-831
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-831
Summary: Can't specify location of web.xml
Type: Bug
Status: Unassigned
Priority: Minor
Time Spent: Unknown
Remaining: Unknown
Project: maven
Components:
plugin-war
Versions:
1.0-beta-10
Assignee:
Reporter: Brian Murray
Created: Fri, 19 Sep 2003 7:56 AM
Updated: Fri, 19 Sep 2003 8:04 AM
Description:
When the WAR plugin was converted from using Ant's <war> task to using the <jar> task we lost the ability to use the ${maven.war.webxml} property to specify the location of the web.xml file. Not only does this reduce flexibility (the only place you can put web.xml is in ${maven.war.src}/WEB-INF/web.xml), but it prevents the token filtering tip (in xdocs/tips.xml) from working.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [jira] Updated: (MAVEN-831) Can't specify location of web.xml
Posted by Brian Murray <br...@vanderbilt.edu>.
Michal Macza said:
Flexibility is not necesserly a good thing.
In current shape of the plugin you are able to define pre- or post- goals
which will do the same exact thing as you patch does. War plugin is not
limiting your possibilities but if you want to do something non standard you
have to do this in non standard way. For me this is very resonable. Keeping
web xml in location different then {maven.war.src}/WEB-INF/web.xml) is a no
standard thing. Mandating non standard project layouts through the set of
configurable properties is imho a very bad thing (even though many plugins
are written in this way).
I am not saying that the way how maven war plugin works currently is the
best thing possible, but if you have better idea how to structure
directories or where web.xml file should be kept - please speak out!
(Token Filtering in web.xml file is a bit different subject! I have nothing
against it!)
Brian Murray replies:
Fundamentally I agree. Plugins with 395 properties to specify every
possible configuration are so complex to use that they're no more helpful
than a plugin with no configurable properties.
In the case of the WAR plug-in I was interpreting a)the inclusion of the
maven.war.webxml in plugin.properties; and b)the reference to it in the tips
document; as indicating a design intent to allow a user of the plug-in to
specify the source of the web.xml file.
So, could I propose an alternative resolution: delete the maven.war.webxml
property from the plug.properties file and update tips.xml to show a
postGoal that doesn't rely on maven.war.webxml. That would eliminate the
confusion I experienced which led me to open the issue.
Personally, I like the property and think it is useful and appropriate. But
in the end I'm just a user.
Brian Murray
Vanderbilt University
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
RE: [jira] Updated: (MAVEN-831) Can't specify location of web.xml
Posted by Michal Maczka <mm...@interia.pl>.
>
> Description:
> When the WAR plugin was converted from using Ant's <war> task to
> using the <jar> task we lost the ability to use the
> ${maven.war.webxml} property to specify the location of the
> web.xml file. Not only does this reduce flexibility (the only
> place you can put web.xml is in
> ${maven.war.src}/WEB-INF/web.xml), but it prevents the token
> filtering tip (in xdocs/tips.xml) from working.
>
>
Flexibility is not necesserly a good thing.
In current shape of the plugin you are able to define pre- or post- goals
which will do the same exact thing as you patch does.
War plugin is not limiting your possibilities but if you want to do
something non standard you have to do this in non standard way.
For me this is very resonable.
Keeping web xml in location different then {maven.war.src}/WEB-INF/web.xml)
is a no standard thing.
Mandating non standard project layouts through the set of configurable
properties is imho a very bad thing
(even though many plugins are written in this way).
I am not saying that the way how maven war plugin works currently is the
best thing possible, but
if you have better idea how to structure directories or where web.xml file
should be kept - please speak out!
(Token Filtering in web.xml file is a bit different subject! I have nothing
against it!)
Michal
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org