You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2026/10/03 21:00:14 UTC

[PR] Upgrade Commons Lang to 3.21.0 and discard trailing empty split fields [pinot]

Jackie-Jiang opened a new pull request, #19747:
URL: https://github.com/apache/pinot/pull/19747

   Commons Lang 3.21.0 removes trailing empty fields from `StringUtils.splitByWholeSeparator`, causing `StringFunctionsTest.testSplitPartRandomized` to fail because Pinot's optimized `splitPart` implementations still retain them. This PR includes the dependency upgrade from #19718 and updates both `splitPart` overloads to discard trailing empty fields, consistently with leading and consecutive empty fields and with `split`/`stringToArray`.
   
   This changes results for inputs ending in a delimiter:
   
   - `split('a,b,', ',')` returns `['a', 'b']` instead of `['a', 'b', '']`.
   - `splitPart('a,b,', ',', -1)` returns `'b'` instead of `''`.
   - `splitPart('a,b,', ',', 2)` returns the existing out-of-range sentinel `'null'` instead of `''`.
   - Delimiter-only input produces no fields.
   
   When a split limit is reached, the final field still contains the unsplit remainder, including trailing delimiters: `split('a,b,', ',', 2)` returns `['a', 'b,']`.
   
   Tests cover single- and multi-character delimiters, negative indexes, delimiter-only input, split limits, and partial delimiter suffixes. The randomized comparison now uses a fixed seed and exercises both overloads against Commons Lang 3.21.0.
   
   Validation:
   
   - `./mvnw -pl pinot-common -am -Dtest=StringFunctionsTest -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.compiler.showDeprecation=true -Dmaven.compiler.showWarnings=true test` — 200 tests passed; no compiler warnings on added lines.
   - `spotless:apply`, `license:format`, `checkstyle:check`, and `license:check` passed for `pinot-common` and the root POM.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Upgrade Commons Lang to 3.21.0 and discard trailing empty split fields [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #19747:
URL: https://github.com/apache/pinot/pull/19747#issuecomment-6005434083

   Documentation follow-up merged: https://github.com/pinot-contrib/pinot-docs/pull/1082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Upgrade Commons Lang to 3.21.0 and discard trailing empty split fields [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19747:
URL: https://github.com/apache/pinot/pull/19747#issuecomment-5973782546

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19747?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 100.00%. Comparing base ([`cd504af`](https://app.codecov.io/gh/apache/pinot/commit/cd504afe901b008671fe77b60ad8e3c393d1515c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2c83645`](https://app.codecov.io/gh/apache/pinot/commit/2c83645c78317257796284db334e865ddfe225b0?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 22 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@              Coverage Diff               @@
   ##             master    #19747       +/-   ##
   ==============================================
   + Coverage     68.16%   100.00%   +31.83%     
   + Complexity     1450         6     -1444     
   ==============================================
     Files          3517         3     -3514     
     Lines        228521         6   -228515     
     Branches      36211         0    -36211     
   ==============================================
   - Hits         155768         6   -155762     
   + Misses        60508         0    -60508     
   + Partials      12245         0    -12245     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-25](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+31.83%)` | :arrow_up: |
   | [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
   | [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+31.83%)` | :arrow_up: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/19747/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19747?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] Upgrade Commons Lang to 3.21.0 and discard trailing empty split fields [pinot]

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #19747:
URL: https://github.com/apache/pinot/pull/19747


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org