You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/08/22 20:42:25 UTC
Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test if
slave recovery behaves correctly during master failover.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
Diff: https://reviews.apache.org/r/13747/diff/
Testing
-------
make check on Linux and OSX.
Thanks,
Jiang Yan Xu
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/#review25447
-----------------------------------------------------------
Ship it!
nice test!
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13747/#comment49851>
s/ack/_statusUpdateAcknowledgement/
this is the new convention. i know some of the old tests in this file do not follow it yet, but we should clean them up at some point.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13747/#comment49853>
s/recover/_recover/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13747/#comment49852>
s/reregisterSlave/reregisterSlaveMessage/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13747/#comment49854>
This should be done in a while loop to ensure reaper reaps it.
while (status.isPending()) {
Clock::advance(Seconds(1));
Clock::settle();
}
- Vinod Kone
On Aug. 22, 2013, 7:37 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13747/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 7:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
> src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
>
> Diff: https://reviews.apache.org/r/13747/diff/
>
>
> Testing
> -------
>
> make check on Linux and OSX.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/#review25489
-----------------------------------------------------------
did you forget to update the diff?
- Vinod Kone
On Aug. 22, 2013, 7:37 p.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13747/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2013, 7:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
> src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
>
> Diff: https://reviews.apache.org/r/13747/diff/
>
>
> Testing
> -------
>
> make check on Linux and OSX.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/#review25529
-----------------------------------------------------------
Ship it!
src/master/master.cpp
<https://reviews.apache.org/r/13747/#comment49977>
s/Cannot/Failed to/
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13747/#comment49978>
This could be pulled up before driver.stop().
- Vinod Kone
On Aug. 24, 2013, 5:41 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13747/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2013, 5:41 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 511332e9d53a224f7473eccaec64b94b4ce5a637
> src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
>
> Diff: https://reviews.apache.org/r/13747/diff/
>
>
> Testing
> -------
>
> make check on Linux and OSX.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/#review25558
-----------------------------------------------------------
committed. pls mark as submitted.
- Vinod Kone
On Aug. 26, 2013, 5:35 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13747/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2013, 5:35 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/master.cpp 511332e9d53a224f7473eccaec64b94b4ce5a637
> src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
>
> Diff: https://reviews.apache.org/r/13747/diff/
>
>
> Testing
> -------
>
> make check on Linux and OSX.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/
-----------------------------------------------------------
(Updated Aug. 26, 2013, 5:35 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
Changes
-------
Vinod's comments.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 511332e9d53a224f7473eccaec64b94b4ce5a637
src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
Diff: https://reviews.apache.org/r/13747/diff/
Testing
-------
make check on Linux and OSX.
Thanks,
Jiang Yan Xu
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/
-----------------------------------------------------------
(Updated Aug. 24, 2013, 5:41 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
Changes
-------
I needed the this patch to avoid this test being flaky... error occurred during test case TearDown(): https://github.com/xujyan/mesos/blob/699d708573737ea0225134bdcaf58f064eda3711/src/tests/mesos.cpp#L223
Looks like I cannot shut down the slave safely without first make sure the executor is terminated. Perhaps a problem with cgroups?
../../src/tests/mesos.cpp:223: Failure
(cgroups::destroy(hierarchy, TEST_CGROUPS_ROOT)).failure(): Failed to kill tasks in nested cgroups: Collect failed: Failed to get tasks of cgroup: Failed to read cgroups control 'tasks': 'mesos_test/framework_201308240424-2081170186-43810-31294-0000_executor_623caa36-c7b4-4aaf-8b28-3e35083b2060_tag_23bbd0b5-fcfd-45dc-8fbc-e0c66b19733d' is not a valid cgroup
[ FAILED ] SlaveRecoveryTest/1.MasterFailover, where TypeParam = mesos::internal::slave::CgroupsIsolator (3299 ms)
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 511332e9d53a224f7473eccaec64b94b4ce5a637
src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
Diff: https://reviews.apache.org/r/13747/diff/
Testing
-------
make check on Linux and OSX.
Thanks,
Jiang Yan Xu
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/
-----------------------------------------------------------
(Updated Aug. 24, 2013, 4:34 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
Changes
-------
Vinod's comment
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp 511332e9d53a224f7473eccaec64b94b4ce5a637
src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
Diff: https://reviews.apache.org/r/13747/diff/
Testing
-------
make check on Linux and OSX.
Thanks,
Jiang Yan Xu
Re: Review Request 13747: Added "SlaveRecoveryTest.MasterFailover" to test
if slave recovery behaves correctly during master failover.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13747/
-----------------------------------------------------------
(Updated Aug. 22, 2013, 7:37 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, and Vinod Kone.
Changes
-------
Rebase. NNFR
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453
src/tests/slave_recovery_tests.cpp 548e8c09875e4d911ac626b15a2556ff4fd8ff4b
Diff: https://reviews.apache.org/r/13747/diff/
Testing
-------
make check on Linux and OSX.
Thanks,
Jiang Yan Xu