You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/08 06:36:47 UTC

[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10657: [feature](Nereids): enforcer job.

EmmyMiao87 commented on code in PR #10657:
URL: https://github.com/apache/doris/pull/10657#discussion_r916498952


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java:
##########
@@ -47,4 +78,162 @@ public void execute() {
             }
         }
     }
+
+    /**
+     * execute.
+     */
+    public void execute1() {
+        // Do init logic of root operator/groupExpr of `subplan`, only run once per task.
+        if (curChildIndex != -1) {
+            curTotalCost = 0;
+
+            // Get property from groupExpression operator (it's root of subplan).
+            ParentRequiredPropertyDeriver parentRequiredPropertyDeriver = new ParentRequiredPropertyDeriver(context);
+            propertiesListList = parentRequiredPropertyDeriver.getRequiredPropertyListList(groupExpression);

Review Comment:
   propertiesListList ?



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/cascades/CostAndEnforcerJob.java:
##########
@@ -47,4 +78,162 @@ public void execute() {
             }
         }
     }
+
+    /**
+     * execute.
+     */
+    public void execute1() {

Review Comment:
   ```suggestion
       // TODO: After the ssb test is completed, this class will replace the execute function to become the real execution class
       public void executeTmp() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org