[GitHub] [incubator-superset] junlincc commented on pull request #11640: fix: Title change made in Edit Chart Properties is not showing on the title

[GitBox <gi...@apache.org>]

junlincc commented on pull request #11640:
URL: https://github.com/apache/incubator-superset/pull/11640#issuecomment-724910773


   @kgabryje and I talked about what the ideal Modal saving behavior should be..  we need to revisit the it and make sure all modal save are consistent across the product. currently we use this modal on chart list view as well and there’s no additional “Save” button. 
   <img width="1738" alt="Screen Shot 2020-11-10 at 11 15 02 AM" src="https://user-images.githubusercontent.com/67837651/98722566-12801980-2346-11eb-9200-781d85ae2ad8.png">
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org