You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Knut O. Hellan (JIRA)" <ji...@apache.org> on 2011/09/13 19:53:09 UTC
[jira] [Created] (THRIFT-1343) no_auto_import min/2 to avoid
compile warning
no_auto_import min/2 to avoid compile warning
---------------------------------------------
Key: THRIFT-1343
URL: https://issues.apache.org/jira/browse/THRIFT-1343
Project: Thrift
Issue Type: Improvement
Components: Erlang - Library
Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
Reporter: Knut O. Hellan
Priority: Trivial
Attachments: no_auto_import_min_2
The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1343) no_auto_import min/2 to avoid
compile warning
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107619#comment-13107619 ]
Anthony Molinaro commented on THRIFT-1343:
------------------------------------------
Any one have any idea why we define our own min/2 function and don't just use erlang:min/2 ? I don't quite know if no_auto_import exists in R13B04 which is still pretty prevalent out there, so was thinking of just replacing calls to min/2 with erlang:min/2. Any of the originaly erlang devs have any history?
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Priority: Trivial
> Labels: patch
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (THRIFT-1343) no_auto_import min/2 to avoid
compile warning
Posted by "Anthony Molinaro (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Molinaro resolved THRIFT-1343.
--------------------------------------
Resolution: Fixed
Fix Version/s: 0.9
I just ended up removing the min function from the 2 files which had it. Thanks for the patch.
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Assignee: Anthony Molinaro
> Priority: Trivial
> Labels: patch
> Fix For: 0.9
>
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (THRIFT-1343) no_auto_import min/2 to
avoid compile warning
Posted by "Knut O. Hellan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107673#comment-13107673 ]
Knut O. Hellan edited comment on THRIFT-1343 at 9/19/11 8:10 AM:
-----------------------------------------------------------------
Compiling and running https://gist.github.com/1226130 with Erlang R13B03 does not give errors and the exported test function works as a min function. Adding the directive should not cause problems for R13B04 either.
That being said, using erlang:min/2 would have made more sense unless the point of the internal functions is to be very visible reminders that they should be removed at some point
was (Author: khellan):
Compiling and running https://gist.github.com/1226130 with Erlang R13B03 does not give errors and the exported test function works as a min function. Adding the directive should not cause problems for R13B04 either.
That being said, using erlang:min/2 would have made more sense unless the point of this is to works as reminders.
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Assignee: Anthony Molinaro
> Priority: Trivial
> Labels: patch
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (THRIFT-1343) no_auto_import min/2 to avoid
compile warning
Posted by "Anthony Molinaro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anthony Molinaro reassigned THRIFT-1343:
----------------------------------------
Assignee: Anthony Molinaro
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Assignee: Anthony Molinaro
> Priority: Trivial
> Labels: patch
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1343) no_auto_import min/2 to avoid
compile warning
Posted by "Knut O. Hellan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Knut O. Hellan updated THRIFT-1343:
-----------------------------------
Attachment: no_auto_import_min_2
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Priority: Trivial
> Labels: patch
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1343) no_auto_import min/2 to avoid
compile warning
Posted by "Knut O. Hellan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107673#comment-13107673 ]
Knut O. Hellan commented on THRIFT-1343:
----------------------------------------
Compiling and running https://gist.github.com/1226130 with Erlang R13B03 does not give errors and the exported test function works as a min function. Adding the directive should not cause problems for R13B04 either.
That being said, using erlang:min/2 would have made more sense unless the point of this is to works as reminders.
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Assignee: Anthony Molinaro
> Priority: Trivial
> Labels: patch
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1343) no_auto_import min/2 to avoid
compile warning
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235454#comment-13235454 ]
Hudson commented on THRIFT-1343:
--------------------------------
Integrated in Thrift #428 (See [https://builds.apache.org/job/Thrift/428/])
THRIFT-1343 - remove internal min function, it seems the same as erlang:min/2 (Revision 1303672)
Result = SUCCESS
molinaro : http://svn.apache.org/viewvc/?view=rev&rev=1303672
Files :
* /thrift/trunk/lib/erl/src/thrift_framed_transport.erl
* /thrift/trunk/lib/erl/src/thrift_memory_buffer.erl
* /thrift/trunk/lib/erl/test
> no_auto_import min/2 to avoid compile warning
> ---------------------------------------------
>
> Key: THRIFT-1343
> URL: https://issues.apache.org/jira/browse/THRIFT-1343
> Project: Thrift
> Issue Type: Improvement
> Components: Erlang - Library
> Environment: I see the warnings when compiling with rebar and Erlang R14B03 on Ubuntu
> Reporter: Knut O. Hellan
> Assignee: Anthony Molinaro
> Priority: Trivial
> Labels: patch
> Fix For: 0.9
>
> Attachments: no_auto_import_min_2
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The compiler issues a warning that is easily avoided with the provided patch
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira