[GitHub] [superset] villebro commented on a change in pull request #13148: refactor(native-filters): decouple filter params from native filters config modal (phase 2)

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #13148:
URL: https://github.com/apache/superset/pull/13148#discussion_r576723567



##########
File path: superset-frontend/src/filters/components/Range/index.ts
##########
@@ -25,7 +25,7 @@ import thumbnail from './images/thumbnail.png';
 export default class AntdRangeFilterPlugin extends ChartPlugin {
   constructor() {
     const metadata = new ChartMetadata({
-      name: t('Range filter plugin'),
+      name: t('Range filter'),

Review comment:
       Slightly unrelated, but while we're at it I think we should drop the `Antd` prefix from the class names and just go with `RangeFilterPlugin` (same for the others).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org